Skip to content

fix: replace remaining uv tool install refs with uv pip install#1930

Merged
aseembits93 merged 1 commit intomainfrom
cf-remove-uv-tool-install-refs
Mar 30, 2026
Merged

fix: replace remaining uv tool install refs with uv pip install#1930
aseembits93 merged 1 commit intomainfrom
cf-remove-uv-tool-install-refs

Conversation

@aseembits93
Copy link
Copy Markdown
Contributor

Summary

Test plan

  • tests/code_utils/test_js_workflow_helpers.py — all 25 tests pass
  • uv run prek — clean
  • Grep confirms zero uv tool references remain in the codebase

🤖 Generated with Claude Code

Follow-up to #1909 — the npm package now installs into a dedicated venv
instead of using uv tool, but these references were missed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 30, 2026

Claude finished @aseembits93's task in 2m 52s —— View job


PR Review Summary

  • Triage PR scope — SMALL (2 production lines changed in init_javascript.py)
  • Run lint/typecheck — prek clean, no issues
  • Check for stale review threads — none
  • Review code changes
  • Duplicate detection
  • Optimization PRs processed

Prek Checks

No issues — prek passed clean.

Code Review

Bug: uv pip install will fail in CI without a virtual environment

The JS workflow template (codeflash-optimize-js.yaml) sets up Python and uv but never creates a virtual environment:

- name: 🐍 Setup Python
  uses: actions/setup-python@v5
- name: 📦 Setup uv
  uses: astral-sh/setup-uv@v4
...
- name: 📥 Install Codeflash
  run: uv pip install codeflash   # ← will fail: "No virtual environment found"

uv pip install requires either an active virtual environment or the --system flag. The original uv tool install codeflash did not have this restriction — it installs a tool globally and works without any venv.

Without a venv, this step will fail with:

error: No virtual environment found; run `uv venv` to create one or pass `--system` to install into a non-virtual environment

The fix is one of:

  • Use uv pip install --system codeflash — installs into the system Python set up by setup-python@v5
  • Add a uv venv && uv pip install codeflash step

Fix this →

Duplicate Detection

No duplicates detected.

Optimization PRs


Last updated: 2026-03-30

@aseembits93 aseembits93 enabled auto-merge March 30, 2026 22:36
@aseembits93 aseembits93 merged commit d31f607 into main Mar 30, 2026
28 of 29 checks passed
@aseembits93 aseembits93 deleted the cf-remove-uv-tool-install-refs branch March 30, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants