Merged
Conversation
jackkoenig
added
the
Internal
It includes an important fix for propagating system properties to ScalaTest when using the native image launcher. This also required updating the unidoc invocation, I made the same change that Mill made to their internal Unidoc.
Contributor
Author
|
I forgot why this was needed, so for posterity, it's because Mill 1.1 uses Scala 3.8 so requires Java 17 which can't publish for older Scala 2.13, see #5202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Improvement
Desired Merge Strategy
Release Notes
It includes an important fix (com-lihaoyi/mill#6774) for propagating system properties to ScalaTest when using the native image launcher.
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.