Revert "Bugfix: .toDefinition should update Builder.definitions"#5199
Closed
Revert "Bugfix: .toDefinition should update Builder.definitions"#5199
Conversation
This reverts commit c13e34b.
Contributor
|
I'll leave this unmerged for now--unless other changes get blocked we can wait till we have a change to debug. I also might need to revert #5196 as publishing seems broken. Anyone using snapshots can stick with |
auto-merge was automatically disabled
February 12, 2026 19:45
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5197
We are seeing issues pulling this change into our codebase. I'm going to revert for now and debug next week.