Skip to content

[PM-33981] feat: Add device management localizations #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andrebispo5 wants to merge 1 commit into
base: pm-33981/innovation-device-list
Choose a base branch
from
+27 −0
Draft

[PM-33981] feat: Add device management localizations #2488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions BitwardenResources/Localizations/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,3 +1330,30 @@
"LearnMoreAboutAutofill" = "Learn more about autofill";
"TurnOnNow" = "Turn on now";
"AcceptTransfer" = "Accept transfer";
"ManageDevices" = "Manage devices";
"NoDevicesFound" = "No devices found";
"CurrentSession" = "Current session";
"PendingRequest" = "Pending request";
"PendingRequests" = "%1$d Pending requests";
Comment on lines +1336 to +1337
Copy link
Copy Markdown
Member

@fedemkr fedemkr Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Localizations that need pluralization based on a parameter should be added in Localizable.stringsdict now so they're handled correctly on all languages.

"Trusted" = "Trusted";
"RecentlyActive" = "Recently active: %1$@";
Copy link
Copy Markdown
Member

@fedemkr fedemkr Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 This has parameter so I'd change it to "RecentlyActiveX"

"RecentlyActiveLabel" = "Recently active:";
"FirstLogin" = "First login: %1$@";
"FirstLoginLabel" = "First login:";
Comment on lines +1340 to +1342
Copy link
Copy Markdown
Member

@fedemkr fedemkr Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ I would use directly "Colon" instead of "Label" as suffix. What do you think @KatherineInCode ?

Copy link
Copy Markdown
Contributor

@KatherineInCode KatherineInCode Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in the category of wondering if there's a better way to do this in general, as I agree with the later comment of not following why there's two of them. But if we do have to have two, then I agree with Colon over Label.

Comment on lines +1341 to +1342
Copy link
Copy Markdown
Member

@fedemkr fedemkr Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Not following why you have two first login localizations? Couldn't you have just the one with the parameter and if the parameter is empty then it's just not shown? Or is there a distinction so the "space" is not shown? Same applies to RecentlyActive

"Today" = "Today";
"ThisWeek" = "This week";
"LastWeek" = "Last week";
"ThisMonth" = "This month";
"OverThirtyDaysAgo" = "Over 30 days ago";
"UnknownDevice" = "Unknown device";
"Unknown" = "Unknown";
"RemoveDevice" = "Remove device";
"AreYouSureYouWantToRemoveDevice" = "Are you sure you want to remove %1$@?";
"AreYouSureYouWantToLogOutDevice" = "Are you sure you want to log out %1$@?";
Comment on lines +1351 to +1352
Copy link
Copy Markdown
Member

@fedemkr fedemkr Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ We often use "X" "Y" "Z" for parameters in the key (if you want you can add a comment to indicate that it represents a device):

Suggested change
"AreYouSureYouWantToRemoveDevice" = "Are you sure you want to remove %1$@?";
"AreYouSureYouWantToLogOutDevice" = "Are you sure you want to log out %1$@?";
"AreYouSureYouWantToRemoveX" = "Are you sure you want to remove %1$@?";
"AreYouSureYouWantToLogOutX" = "Are you sure you want to log out %1$@?";

"Mobile" = "Mobile";
"BrowserExtension" = "Browser extension";
"WebVault" = "Web vault";
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebVault is already defined earlier in this file (currently as "Bitwarden web vault"). Adding a second WebVault entry here will override the earlier value at runtime, potentially changing existing UI text unexpectedly. Please either reuse the existing WebVault value (and remove this new entry) or introduce a distinct key for the shorter device-type label (e.g., WebVaultDeviceType/WebVaultShort).

Suggested change
"WebVault" = "Web vault";
"WebVaultDeviceType" = "Web vault";

Copilot uses AI. Check for mistakes.
"Desktop" = "Desktop";
"Cli" = "CLI";
"Sdk" = "SDK";
"Server" = "Server";
Loading