[PM-33981] feat: Add device management localizations#2488
[PM-33981] feat: Add device management localizations#2488andrebispo5 wants to merge 1 commit intopm-33981/innovation-device-listfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new English localization keys to support the Device Management feature UI, including device/session status labels and device-type strings.
Changes:
- Added device management UI strings (manage devices, empty state, session/status labels).
- Added date-range labels for activity recency.
- Added device type labels (mobile, browser extension, web vault, desktop, CLI, SDK, server).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "AreYouSureYouWantToLogOutDevice" = "Are you sure you want to log out %1$@?"; | ||
| "Mobile" = "Mobile"; | ||
| "BrowserExtension" = "Browser extension"; | ||
| "WebVault" = "Web vault"; |
There was a problem hiding this comment.
WebVault is already defined earlier in this file (currently as "Bitwarden web vault"). Adding a second WebVault entry here will override the earlier value at runtime, potentially changing existing UI text unexpectedly. Please either reuse the existing WebVault value (and remove this new entry) or introduce a distinct key for the shorter device-type label (e.g., WebVaultDeviceType/WebVaultShort).
| "WebVault" = "Web vault"; | |
| "WebVaultDeviceType" = "Web vault"; |
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pm-33981/innovation-device-list #2488 +/- ##
===================================================================
- Coverage 86.87% 85.72% -1.16%
===================================================================
Files 1846 2079 +233
Lines 162969 177860 +14891
===================================================================
+ Hits 141572 152462 +10890
- Misses 21397 25398 +4001 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "PendingRequest" = "Pending request"; | ||
| "PendingRequests" = "%1$d Pending requests"; |
There was a problem hiding this comment.
Localizable.stringsdict now so they're handled correctly on all languages.
| "RecentlyActiveLabel" = "Recently active:"; | ||
| "FirstLogin" = "First login: %1$@"; | ||
| "FirstLoginLabel" = "First login:"; |
There was a problem hiding this comment.
⛏️ I would use directly "Colon" instead of "Label" as suffix. What do you think @KatherineInCode ?
There was a problem hiding this comment.
I'm in the category of wondering if there's a better way to do this in general, as I agree with the later comment of not following why there's two of them. But if we do have to have two, then I agree with Colon over Label.
| "PendingRequest" = "Pending request"; | ||
| "PendingRequests" = "%1$d Pending requests"; | ||
| "Trusted" = "Trusted"; | ||
| "RecentlyActive" = "Recently active: %1$@"; |
There was a problem hiding this comment.
🎨 This has parameter so I'd change it to "RecentlyActiveX"
| "FirstLogin" = "First login: %1$@"; | ||
| "FirstLoginLabel" = "First login:"; |
There was a problem hiding this comment.
🤔 Not following why you have two first login localizations? Couldn't you have just the one with the parameter and if the parameter is empty then it's just not shown? Or is there a distinction so the "space" is not shown? Same applies to RecentlyActive
| "AreYouSureYouWantToRemoveDevice" = "Are you sure you want to remove %1$@?"; | ||
| "AreYouSureYouWantToLogOutDevice" = "Are you sure you want to log out %1$@?"; |
There was a problem hiding this comment.
⛏️ We often use "X" "Y" "Z" for parameters in the key (if you want you can add a comment to indicate that it represents a device):
| "AreYouSureYouWantToRemoveDevice" = "Are you sure you want to remove %1$@?"; | |
| "AreYouSureYouWantToLogOutDevice" = "Are you sure you want to log out %1$@?"; | |
| "AreYouSureYouWantToRemoveX" = "Are you sure you want to remove %1$@?"; | |
| "AreYouSureYouWantToLogOutX" = "Are you sure you want to log out %1$@?"; |

Depends on: #2487
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33981
📔 Objective
Add localized strings for the device management feature including device types, activity status labels, and UI text.