Skip to content

[PM-33576] llm: Add orchestration command, agent, and skill index to CLAUDE.md#2450

Open
SaintPatrck wants to merge 2 commits intomainfrom
llm/orchestration
Open

[PM-33576] llm: Add orchestration command, agent, and skill index to CLAUDE.md#2450
SaintPatrck wants to merge 2 commits intomainfrom
llm/orchestration

Conversation

@SaintPatrck
Copy link
Copy Markdown
Contributor

@SaintPatrck SaintPatrck commented Mar 13, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33576

📔 Objective

Adds the final orchestration layer: a /work-on-ios command that sequences all skills end-to-end, an autonomous agent for hands-off execution, and a skill/command index in CLAUDE.md.

What changed:

  • commands/work-on-ios.md — 7-phase guided workflow with user confirmation between each phase: implement → test → build & verify → self-review → commit → code review → create draft PR. Invokes the appropriate skill at each phase. Structured to match the Android work-on-android.md template.

  • commands/plan-ios-work.md — 3-phase planning command: ingest requirements (Jira or description) → refine with gap analysis → design implementation approach. Plans are presented in-context rather than saved to disk.

  • agents/ios-implementer/AGENT.md — Opus model, blue. Runs /work-on-ios as primary workflow with a self-review protocol at each phase transition, auto-approving when criteria are met. Includes decision-making framework and explicit skill tool declarations. Aligned with the Android android-implementer agent structure.

  • CLAUDE.md — Adds a Skills & Commands index table: 10 skills with trigger phrases, and 2 commands with usage descriptions.

This is the final commit in the 7-PR series (PM-33570 through PM-33576) that brings the iOS .claude/ configuration to full parity with the Android template.

@github-actions github-actions bot added the t:llm Change Type - LLM related change (e.g. CLAUDE.md files) label Mar 13, 2026
@SaintPatrck SaintPatrck added the ai-review Request a Claude code review label Mar 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2026

Logo
Checkmarx One – Scan Summary & Details4a0db958-f3b5-4a63-81ba-be764b333895

Great job! No new security vulnerabilities introduced in this pull request

@claude
Copy link
Copy Markdown

claude bot commented Mar 13, 2026

Claude finished @SaintPatrck's task in 3m 54s —— View job


I'll analyze this and get back to you.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.95%. Comparing base (78b9e6c) to head (88a6d8c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2450      +/-   ##
==========================================
- Coverage   87.08%   85.95%   -1.13%     
==========================================
  Files        1862     2092     +230     
  Lines      165404   180212   +14808     
==========================================
+ Hits       144040   154907   +10867     
- Misses      21364    25305    +3941     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


## Phase 1: Load or Create Plan

Check for an existing plan at `.claude/outputs/plans/`:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 We don't have a .gitignore of some sort set up against this directory, which means, are we anticipating now that we'll be committing Claude's generated plans into the repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This shouldn't reference any specific file locations yet. However, I do suggest making a global ~/.gitignore_global entry to a common place for Claude to safely drop its outputs. As you can see, I use .claude/outputs/.

Once these tools are converted to plugins, they'll have their own output locations outside of any repo/project context. 🚀

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S.

I removed the references and realigned with the Android counterpart. Thanks for calling this out.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My just base-level plan-mode documents have been going in ~/.claude/plans for the time being, which is a mite inconvenient. Probably something for me to consider doing some more reconfiguration around 🤔

…CLAUDE.md

- /work-on-ios command: 7-phase workflow with user confirmation between
  phases — load/create plan, implement, write tests, build/verify, preflight,
  commit, create PR + label
- ios-implementer agent: opus model, blue color; invokes /work-on-ios as
  primary workflow; auto-approves phase transitions; enforces security,
  test, and PR creation constraints
- outputs/plans/.gitkeep: directory for design docs saved by planning skills
- CLAUDE.md: add Skills & Commands index table at end of file (10 skills,
  2 commands with trigger phrases and usage)
…plans directory

- Restructure work-on-ios.md to match work-on-android.md pattern
- Remove plan-loading phase, add review phase with code-review-local
- Remove .claude/outputs/plans/ directory (addresses gitignore concern)
- Align ios-implementer agent with android-implementer structure
- Update plan-ios-work.md to present plans in-context instead of saving to disk
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed changes across 4 files in the .claude/ directory: a new /work-on-ios command with a 7-phase guided workflow, a new ios-implementer autonomous agent definition, updates to plan-ios-work.md removing disk-based plan saving (Phase 4) and domain mapping, and a Skills and Commands index table added to CLAUDE.md. All changes are LLM configuration only with no impact on application code, security, or runtime behavior.

Code Review Details

No findings. Changes are internally consistent, align with the stated objective of matching the Android template structure, and address the prior review feedback regarding committing generated plans by removing the disk-saving phase entirely.

@SaintPatrck SaintPatrck marked this pull request as ready for review April 8, 2026 17:50
@SaintPatrck SaintPatrck requested review from a team as code owners April 8, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:llm Change Type - LLM related change (e.g. CLAUDE.md files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants