Skip to content

[SPARK-56165][PYTHON][TESTS] Use temporary directory instead of saveAsTable in test_data_source_segfault #54964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yicong-Huang wants to merge 2 commits into from
+6 −8
Closed

[SPARK-56165][PYTHON][TESTS] Use temporary directory instead of saveAsTable in test_data_source_segfault #54964

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bbcb39
[SPARK-56165][PYTHON][TESTS] Use temporary directory instead of saveA…
Yicong-Huang Mar 23, 2026
2cd44c0
Merge branch 'apache:master' into SPARK-56165
Yicong-Huang Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions python/pyspark/sql/tests/test_python_datasource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,10 +919,9 @@ def write(self, iterator):

self.spark.dataSource.register(TestDataSource)

with self.assertRaisesRegex(Exception, expected):
self.spark.range(10).write.format("test").mode("append").saveAsTable(
"test_table"
)
with tempfile.TemporaryDirectory(prefix="test_segfault_") as d:
with self.assertRaisesRegex(Exception, expected):
self.spark.range(10).write.format("test").mode("append").save(d)

with self.subTest(worker="pyspark.sql.worker.commit_data_source_write"):

Expand All @@ -943,10 +942,9 @@ def commit(self, messages):

self.spark.dataSource.register(TestDataSource)

with self.assertRaisesRegex(Exception, expected):
self.spark.range(10).write.format("test").mode("append").saveAsTable(
"test_table"
)
with tempfile.TemporaryDirectory(prefix="test_segfault_") as d:
with self.assertRaisesRegex(Exception, expected):
self.spark.range(10).write.format("test").mode("append").save(d)

@unittest.skipIf(is_remote_only(), "Requires JVM access")
def test_data_source_reader_with_logging(self):
Expand Down