[SPARK-56165][PYTHON][TESTS] Use temporary directory instead of saveAsTable in test_data_source_segfault#54964
Closed
Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-56165][PYTHON][TESTS] Use temporary directory instead of saveAsTable in test_data_source_segfault#54964Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Yicong-Huang wants to merge 2 commits intoapache:masterfrom
Conversation
…sTable in test_data_source_segfault
### What changes were proposed in this pull request?
Replace `saveAsTable("test_table")` with `.save(tempdir)` in `test_data_source_segfault`'s two write/commit subtests.
### Why are the changes needed?
`saveAsTable()` triggers catalog format validation which can reject the custom `"test"` data source format. Using `.save(tempdir)` avoids catalog validation while exercising the same Python worker write/commit code paths. This is also consistent with how other write tests in the same file are structured.
### Does this PR introduce _any_ user-facing change?
No. Test-only change.
### How was this patch tested?
`python/pyspark/sql/tests/test_python_datasource.py::test_data_source_segfault` (12 subtests passed).
### Was this patch authored or co-authored using generative AI tooling?
No.
Contributor
Author
allisonwang-db
approved these changes
Mar 23, 2026
HyukjinKwon
approved these changes
Mar 23, 2026
ueshin
approved these changes
Mar 23, 2026
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace
saveAsTable("test_table")with.save(tempdir)intest_data_source_segfault's two write/commit subtests.Why are the changes needed?
This is consistent with how other write tests in the same file are structured.
Does this PR introduce any user-facing change?
No. Test-only change.
How was this patch tested?
python/pyspark/sql/tests/test_python_datasource.py::test_data_source_segfaultWas this patch authored or co-authored using generative AI tooling?
No.