Conversation
… preview metrics + post-merge-feedback 結果)
…(../docs/` 検出 (順位 94 / Bundle j-1)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthrough新しいカスタムリントルール ChangesMD相対リンク検出ルール実装・テスト・ドキュメント更新
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/配下から../docs/への back-link を検出する custom lint rule⑧ (no-docs-relative-back-to-docs) を追加。Phase d roster の P-2 (Bundle j-1 / 順位 94) に該当。(?i)\]\(\.\./docs/regex 1 行で PR docs(todo): split summary and todo5.md tasks to keep files under 50KB #133 と同型の broken link bug class を pre-push で block../<other-dir>/skip / 拡張子限定 (md のみ)変更内容
Commit 1 (前 PR carry-over): 順位 100 登録 + analysis.md P-1 完了反映
PR #139 (Bundle h+g-2) merge 後の post-merge-feedback で採用された Tier 3 #1 (
development-workflow.mdに「同一ファイル複数編集の 1 task 統合」+「partial completion + 後続 PR 追補明記」 の 2 pattern 追補) を 順位 100 としてdocs/todo6.md+docs/todo-summary.mdに登録、analysis.md §4 #2の P-1 行を ✅ 完了化 + dogfood outcome (classifier preview metrics + post-merge-feedback 結果) を記載。本 commit は前 PR からの「フィードバック層」carry-over で、本 PR の P-2 implementation とは独立。
Commit 2: rule⑧ 追加 + linter test + 順位 94 cleanup
.claude/custom-lint-rules.tomlルール⑧
no-docs-relative-back-to-docsを追加 (severity =error):(?i)\]\(\.\./docs/["md"]error自己限定設計:
pathsfilter は lint runner 未実装 (extensionsのみサポート)。pattern semantics で自己限定可:](../docs/は parent-dir 経由でdocs/を再参照する形で、root-level README / docs 外の Markdown では自然な link 形式](docs/...)(相対なし) と区別される。grep 確認で false positive 影響範囲は todo6.md の説明文 1 件のみ (本 PR で削除)。src/hooks-post-tool-linter/src/main.rs5 件の synthetic test:
md_no_docs_relative_detects_pr133_pattern: PR docs(todo): split summary and todo5.md tasks to keep files under 50KB #133 で混入した[ADR-036](../docs/adr/adr-036-...)形式の検出を確認md_no_docs_relative_detects_uppercase_path:../DOCS/...大文字バリアント (case-insensitive) の検出md_no_docs_relative_skips_same_directory_link: 同階層[text](adr/foo.md)(相対参照なし) は skipmd_no_docs_relative_skips_parent_to_other_dir:../README.md/../src/main.rs等 docs 以外への parent-dir 参照は skipmd_no_docs_relative_only_targets_md:.toml等の他拡張子は対象外 (extensions = ["md"] 確認)全 87 test pass、新規 5 test 含む。
todo cleanup
docs/todo6.md: 順位 94 (docs/内 Markdown の../docs/相対パストラップ検出 lint rule) 詳細削除docs/todo-summary.md: priority table から 順位 94 行削除、Bundle j 解説で j-1 land 済を明記Phase d P-2 dogfood signal (classifier preview のみ、real pipeline 未実行)
P-1 と同じ方針 (
feedback_global_config_backupを踏まえた commit pollution 回避):human_review(fallback)human_review(fallback)screen_decision観測:
num_ctxoverflow detection) の必要性が再々確認、P-3 着手前の優先実装を推奨real pipeline 経由の P-2 metric は未取得。P-3 移行時に再判断。
Test plan
cargo test -p hooks-post-tool-linter— 87/87 pass (新規 5 test 含む)pnpm deploy:hooksでビルド・デプロイ確認Out of scope
pathsfilter の lint runner 実装: 現状extensionsのみ。多数の false positive 観測時は別 PR で実装検討num_ctxoverflow detection): P-2 fallback で再確認したが本 PR scope 外、別 PR で実施docs/構造確認が必要、別タイミングで実施Summary by CodeRabbit
リリースノート
New Features
Documentation
Tests