Skip to content

fix: reject whitespace-only SQL in frontend validation (#593) #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LZS911 merged 1 commit into from
Apr 13, 2026
Merged

fix: reject whitespace-only SQL in frontend validation (#593) #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dms-kit/src/utils/FormRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const whiteSpaceSqlValidator = (
): FormValidatorRule => {
return (_, values) => {
const placeholder = '/* input your sql */';
if (values === placeholder && enableRule) {
if (enableRule && (values === placeholder || !values?.trim())) {
return Promise.reject(
i18n.t('common.form.placeholder.input', {
name: i18n.t('common.sqlStatements')
Expand Down
11 changes: 11 additions & 0 deletions packages/dms-kit/src/utils/__tests__/FormRule.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,17 @@ describe('utils/FormRule', () => {
expect(message).toBe('请输入SQL语句');
});

it('should reject whitespace-only sql', async () => {
const check = whiteSpaceSqlValidator();
let message = '';
try {
await check?.({} as any, ' ', () => {});
} catch (error: any) {
message = error;
}
expect(message).toBe('请输入SQL语句');
});

it('should not check white space sql when enableRule is false', async () => {
const check = whiteSpaceSqlValidator(false);
let message = '';
Expand Down
Loading