fix: reject whitespace-only SQL in frontend validation (#593)#815
Merged
fix: reject whitespace-only SQL in frontend validation (#593)#815
Conversation
EDGE-BUG-001: The whiteSpaceSqlValidator only checked for the placeholder value but did not reject whitespace-only input (spaces, tabs, etc). This allowed whitespace SQL to bypass frontend validation and reach the backend. Updated the validator to also reject values that are empty or contain only whitespace characters using trim(). Added test case for the whitespace-only scenario.
Coverage report
Test suite run success3646 tests passing in 814 suites. Report generated by 🧪jest coverage report action from 43ded98 |
LZS911
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related: https://github.com/actiontech/dms-ee/issues/777