Skip to content

Refactor Styles into separate CSS#143

Open
SharonStrats wants to merge 26 commits intomainfrom
refactor/styles-separateCSS
Open

Refactor Styles into separate CSS#143
SharonStrats wants to merge 26 commits intomainfrom
refactor/styles-separateCSS

Conversation

@SharonStrats
Copy link

@SharonStrats SharonStrats commented Mar 11, 2026

For ticket SolidOS/solidos#238

  • Create CSS files and import them
  • Build from one file

Retested importing into solid-panes from local meeting-pane.

Copilot AI review requested due to automatic review settings March 11, 2026 05:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors Meeting Pane styling out of inline JS styles into standalone CSS, and updates the webpack build to process CSS and produce both normal and minified library bundles.

Changes:

  • Added shared moduleRules (JS/TS, CSS, CSS modules, TTL) and wired them into both dev and prod webpack configs.
  • Moved various inline styles in src/index.js into src/styles/meetingPane.css and imported the CSS from the entrypoint.
  • Updated packaging/build output to write to lib/ and added new typings files (index.d.ts, declarations.d.ts).

Reviewed changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
webpack.module.rules.mjs New shared webpack loader rules including CSS handling.
webpack.dev.config.mjs Switched dev build to use shared rules (but currently missing an import).
webpack.config.mjs Refactored production build into common + normal/min configs; added copying of styles and terser minification.
src/styles/meetingPane.css New stylesheet replacing several previously inline styles.
src/index.js Imports CSS and replaces inline styles with class-based styling.
package.json Changes published entrypoints and published files, and adds CSS/tooling deps.
package-lock.json Locks new build dependencies (css-loader, style-loader, copy-webpack-plugin, terser-webpack-plugin, etc.).
index.d.ts New type entry file re-exporting declarations.
declarations.d.ts Adds PaneDefinition typing and default export declaration for the pane.
dev/index.js Updates dev entry to import from src/index and loads a dev-global CSS file; changes demo URL.
dev/dev-global.css Adds local-dev global CSS variables/resets used by the refactored CSS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants