Open
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors Meeting Pane styling out of inline JS styles into standalone CSS, and updates the webpack build to process CSS and produce both normal and minified library bundles.
Changes:
- Added shared
moduleRules(JS/TS, CSS, CSS modules, TTL) and wired them into both dev and prod webpack configs. - Moved various inline styles in
src/index.jsintosrc/styles/meetingPane.cssand imported the CSS from the entrypoint. - Updated packaging/build output to write to
lib/and added new typings files (index.d.ts,declarations.d.ts).
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.module.rules.mjs | New shared webpack loader rules including CSS handling. |
| webpack.dev.config.mjs | Switched dev build to use shared rules (but currently missing an import). |
| webpack.config.mjs | Refactored production build into common + normal/min configs; added copying of styles and terser minification. |
| src/styles/meetingPane.css | New stylesheet replacing several previously inline styles. |
| src/index.js | Imports CSS and replaces inline styles with class-based styling. |
| package.json | Changes published entrypoints and published files, and adds CSS/tooling deps. |
| package-lock.json | Locks new build dependencies (css-loader, style-loader, copy-webpack-plugin, terser-webpack-plugin, etc.). |
| index.d.ts | New type entry file re-exporting declarations. |
| declarations.d.ts | Adds PaneDefinition typing and default export declaration for the pane. |
| dev/index.js | Updates dev entry to import from src/index and loads a dev-global CSS file; changes demo URL. |
| dev/dev-global.css | Adds local-dev global CSS variables/resets used by the refactored CSS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ticket SolidOS/solidos#238
Retested importing into solid-panes from local meeting-pane.