Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the participants picker crash (issue #137) and introduces a CSS pipeline so the meeting pane can ship its own styling when bundled/published.
Changes:
- Refactors participants picker initialization to avoid
context.index.privateaccess and improve error handling. - Adds webpack CSS handling + new meeting-pane styles, and updates build outputs to
lib/(including minified build). - Adds TypeScript declaration entrypoints (
index.d.ts,declarations.d.ts) and updates package metadata for publishing.
Reviewed changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/meetingPane.js |
Fixes participants picker logic; replaces inline styles with CSS classes and adds CSS imports. |
src/styles/meetingPane.css |
New meeting-pane styling for layout/icon rendering. |
src/styles/utilities.css |
Adds shared CSS variables for icon sizing. |
webpack.module.rules.mjs |
Centralizes module rules and adds CSS/CSS-modules support. |
webpack.dev.config.mjs |
Uses shared module rules. |
webpack.config.mjs |
Produces normal + minified bundles, copies styles into lib/styles. |
package.json |
Switches publish output from dist/ to lib/, adds CSS sideEffects + dependencies. |
package-lock.json |
Locks new webpack/CSS related dependencies. |
declarations.d.ts / index.d.ts |
Adds exported TS types for the pane. |
dev/index.js / dev/dev-global.css |
Adds dev-only global CSS for local testing. |
README.md |
Documents AI-generated code usage. |
.gitignore |
Removes dist ignore entries (build output now lib/). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| .meetingPane .meetingToolIcon-visible { | ||
| display: inline-block !important; | ||
| opacity: 100% !important; | ||
| } |
| } | ||
|
|
||
| .meetingPane .meetingToolIcon-disabled { | ||
| opacity: 30%; |
|
|
||
| Bring together schedule, people, materials, discussion around a meeting. | ||
|
|
||
| ## Genertive AI usage |
Comment on lines
+5
to
+9
| "main": "lib/meeting-pane.js", | ||
| "types": "lib/index.d.ts", | ||
| "sideEffects": [ | ||
| "**/*.css" | ||
| ], |
| "dist/", | ||
| "lib/", | ||
| "README.md", | ||
| "LICENSE" |
Comment on lines
+1083
to
+1086
| if (!chosenScope || !chosenScope.index) { | ||
| complain('No type index available for this user to load participants.') | ||
| return | ||
| } |
Member
|
@SharonStrats you can open a PR against that branch that you need merged first, so it is easier for reviers to follow what the concrete changes are on this PR. |
Author
|
change merge into branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #137
PR #143 needs to be merged first.