Skip to content

[Feats] Invoke model faster #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duydoantechx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Feats] Invoke model faster #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/bedrock_llm/client/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ async def _invoke_model_async(
accept="application/json",
contentType="application/json",
body=json.dumps(request_body),
performanceConfigLatency = "optimized"
Copy link
Copy Markdown

@devloai devloai Bot Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove spaces around = in keyword argument to match PEP 8 style. Also, this parameter should be aligned with the others above it.

Suggested change
performanceConfigLatency = "optimized"
performanceConfigLatency="optimized"

Copy link
Copy Markdown

@devloai devloai Bot Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding the same performance optimization to the sync client's _invoke_model_sync method for consistency. If there's a reason why it should only be applied to async calls, please document this in a comment.

)

async def close(self):
Expand Down