Conversation
|
Automatic code review is enabled for this repository. Reviewing this PR now. |
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes look good overall, adding performance optimization for model invocation. I've suggested a minor style fix for parameter formatting and raised a consideration about sync/async consistency. Please address these points to improve code quality and maintainability.
| accept="application/json", | ||
| contentType="application/json", | ||
| body=json.dumps(request_body), | ||
| performanceConfigLatency = "optimized" |
There was a problem hiding this comment.
Remove spaces around = in keyword argument to match PEP 8 style. Also, this parameter should be aligned with the others above it.
| performanceConfigLatency = "optimized" | |
| performanceConfigLatency="optimized" |
| accept="application/json", | ||
| contentType="application/json", | ||
| body=json.dumps(request_body), | ||
| performanceConfigLatency = "optimized" |
There was a problem hiding this comment.
Consider adding the same performance optimization to the sync client's _invoke_model_sync method for consistency. If there's a reason why it should only be applied to async calls, please document this in a comment.
1 participant
No description provided.