-
-
Notifications
You must be signed in to change notification settings - Fork 928
[16.0][ADD] purchase_date_planned_manual_container_deposit_product: When date_planned is set manually, prevent calculation of the field up #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
92 changes: 92 additions & 0 deletions
92
purchase_date_planned_manual_container_deposit_product/README.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| ====================================================== | ||
| Purchase Date Planned Manual Container Deposit Product | ||
| ====================================================== | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:096a81afacd9b853ef576065aea83f9d832947fdf5d82dc030006591e710d643 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
|
||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Beta | ||
| .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/purchase-workflow/tree/16.0/purchase_date_planned_manual_container_deposit_product | ||
| :alt: OCA/purchase-workflow | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_date_planned_manual_container_deposit_product | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&target_branch=16.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module makes the system to always respect the planned (or scheduled) | ||
| date set by the user in PO when choose product with packaging container deposit. | ||
|
|
||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Usage | ||
| ===== | ||
|
|
||
| To test this module you could follow below: | ||
|
|
||
| #. Go to 'Purchase' and create a purchase order. | ||
| #. Select any vendor | ||
| #. Add new PO Line with product with container deposit associated | ||
| #. Enter Expected Arrival (date_planned) in future | ||
| #. Confirm PO | ||
| #. Expected Arrival is preserved | ||
|
|
||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/purchase-workflow/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_date_planned_manual_container_deposit_product%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ~~~~~~~ | ||
|
|
||
| * Camptocamp | ||
|
|
||
| Contributors | ||
| ~~~~~~~~~~~~ | ||
|
|
||
| * Chau Le <chaulb@trobz.com> | ||
|
|
||
|
|
||
| Maintainers | ||
| ~~~~~~~~~~~ | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| This module is part of the `OCA/purchase-workflow <https://github.com/OCA/purchase-workflow/tree/16.0/purchase_date_planned_manual_container_deposit_product>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
1 change: 1 addition & 0 deletions
1
purchase_date_planned_manual_container_deposit_product/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import models |
19 changes: 19 additions & 0 deletions
19
purchase_date_planned_manual_container_deposit_product/__manifest__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Copyright 2024 Camptocamp | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
| { | ||
| "name": "Purchase Date Planned Manual Container Deposit Product", | ||
| "summary": """Glue module between purchase_date_planned_manual | ||
| and purchase_product_packaging_container_deposit""", | ||
| "version": "16.0.1.0.0", | ||
| "author": "Camptocamp, " "Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/purchase-workflow", | ||
| "category": "Purchase Management", | ||
| "depends": [ | ||
| "purchase_date_planned_manual", | ||
| "purchase_product_packaging_container_deposit", | ||
| ], | ||
| "license": "AGPL-3", | ||
| "installable": True, | ||
| "application": False, | ||
| "auto_install": True, | ||
| } |
1 change: 1 addition & 0 deletions
1
purchase_date_planned_manual_container_deposit_product/models/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import purchase_order |
14 changes: 14 additions & 0 deletions
14
purchase_date_planned_manual_container_deposit_product/models/purchase_order.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Copyright 2024 Camptocamp | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
| from odoo import models | ||
|
|
||
|
|
||
| class PurchaseOrder(models.Model): | ||
| _inherit = "purchase.order" | ||
|
|
||
| def prepare_deposit_container_line(self, product, qty): | ||
| values = super().prepare_deposit_container_line(product, qty) | ||
| if self.date_planned: | ||
| values["date_planned"] = self.date_planned | ||
|
|
||
| return values | ||
2 changes: 2 additions & 0 deletions
2
purchase_date_planned_manual_container_deposit_product/readme/CONTRIBUTORS.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| * Chau Le <chaulb@trobz.com> | ||
|
|
3 changes: 3 additions & 0 deletions
3
purchase_date_planned_manual_container_deposit_product/readme/DESCRIPTION.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| This module makes the system to always respect the planned (or scheduled) | ||
| date set by the user in PO when choose product with packaging container deposit. | ||
|
|
9 changes: 9 additions & 0 deletions
9
purchase_date_planned_manual_container_deposit_product/readme/USAGE.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| To test this module you could follow below: | ||
|
|
||
| #. Go to 'Purchase' and create a purchase order. | ||
| #. Select any vendor | ||
| #. Add new PO Line with product with container deposit associated | ||
| #. Enter Expected Arrival (date_planned) in future | ||
| #. Confirm PO | ||
| #. Expected Arrival is preserved | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment is welcome, why the
values["date_planned"]is overridden here and we need to fix it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepare_deposit_container_linewill return values to create a new purchase order line with the container deposit product. If we enter Expected Arrivaldate_plannedin the purchase order, we need to send the date_planned from the purchase order to the purchase order line. If not, the new purchase order line will have date_planned as today.The method I override and where it was executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sebalix , Do you want to reopen this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi guys, it's seems to be good for me, could we reopen the pr and merge ? @chaule97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cyrilmanuel , can we merge #2979?