Conversation
chaule97
force-pushed
the
16.0-fix-purchase_date_planned_manual
branch
2 times, most recently
from
f77c2ad to
b5e589a
Compare
purchase_date_planned_manual_container_deposit_product/readme/USAGE.rst
Outdated
Show resolved
Hide resolved
|
|
||
| def prepare_deposit_container_line(self, product, qty): | ||
| values = super().prepare_deposit_container_line(product, qty) | ||
| if self.date_planned: |
There was a problem hiding this comment.
A comment is welcome, why the values["date_planned"] is overridden here and we need to fix it?
There was a problem hiding this comment.
prepare_deposit_container_line will return values to create a new purchase order line with the container deposit product. If we enter Expected Arrival date_planned in the purchase order, we need to send the date_planned from the purchase order to the purchase order line. If not, the new purchase order line will have date_planned as today.
There was a problem hiding this comment.
hi guys, it's seems to be good for me, could we reopen the pr and merge ? @chaule97
…te_planned is set manually, prevent calculation of the field upon PO confirmation
chaule97
force-pushed
the
16.0-fix-purchase_date_planned_manual
branch
from
b5e589a to
75173d9
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
3 participants
purchase_date_planned_manual_container_deposit_product: When date_planned is set manually and add product attached to container deposit, this glue module makes those purchase order lines have a same date_planned