Skip to content

vcv-rack: update apple-sdk to 14 to fix eval#460315

Merged
K900 merged 1 commit intoNixOS:masterfrom
leona-ya:push-qmmmmvzowzol
Nov 10, 2025
Merged

vcv-rack: update apple-sdk to 14 to fix eval#460315
K900 merged 1 commit intoNixOS:masterfrom
leona-ya:push-qmmmmvzowzol

Conversation

@leona-ya
Copy link
Copy Markdown
Member

@leona-ya leona-ya commented Nov 10, 2025 •
edited
Loading

see #332358 (comment). #332358 broke eval on staging-next, as apple-sdk_13 was dropped in 0f6b88a.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested review from jpotier and nathyong November 10, 2025 10:54
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 10, 2025
afh
afh approved these changes Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on so quickly, @leona-ya, much appreciated!

@K900 K900 added this pull request to the merge queue Nov 10, 2025
Merged via the queue into NixOS:master with commit 79b9a72 Nov 10, 2025
30 checks passed
@LordGrimmauld LordGrimmauld mentioned this pull request Nov 10, 2025
Merged
13 tasks
@aduh95 aduh95 mentioned this pull request Nov 10, 2025
Merged
13 tasks
@leona-ya leona-ya deleted the push-qmmmmvzowzol branch November 10, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afh afh afh approved these changes

@jpotier jpotier Awaiting requested review from jpotier

@nathyong nathyong Awaiting requested review from nathyong

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leona-ya @afh @K900