python3Packages.pygame{,-ce}: fix tests with new sdl2-compat#460025
Merged
LordGrimmauld merged 2 commits intoNixOS:staging-nextfrom Nov 10, 2025
Merged
python3Packages.pygame{,-ce}: fix tests with new sdl2-compat#460025LordGrimmauld merged 2 commits intoNixOS:staging-nextfrom
LordGrimmauld merged 2 commits intoNixOS:staging-nextfrom
Conversation
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
marcin-serwin
force-pushed
the
push-pmtwwtpsvtwv
branch
from
c78484a to
0fa3aaa
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
LordGrimmauld
approved these changes
Nov 10, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Thank you for looking into these! And as always, good job with handling upstream reports and drafting fixes.
Contributor
|
Ofborg seems happy, and the code changes look reasonable. Merging. |
nixpkgs-ci
bot
added
the
12.approvals: 1
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Huh, seems merge queue failed.... I'll try again |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Eval fixed in #460315, so i can merge now for real |
Merged
via the queue into
NixOS:staging-next
with commit Nov 10, 2025
1d9d83e
33 of 34 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported in #457099 (comment)
cc @LordGrimmauld
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.