Skip to content

fix(scripts): add signal handlers to nemoclaw-start.sh #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dknos wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −2
Open

fix(scripts): add signal handlers to nemoclaw-start.sh #1488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions scripts/nemoclaw-start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,30 @@ if [ -w "$_SANDBOX_HOME" ]; then
_write_proxy_snippet "${_SANDBOX_HOME}/.profile"
fi

# ── Signal handling ─────────────────────────────────────────────
# This script runs as PID 1 (ENTRYPOINT). Without signal forwarding,
# SIGTERM from Docker/Kubernetes is not propagated to child processes,
# leaving the gateway (and any auto-pair watcher) orphaned until the
# container's kill timeout expires. Ref: #1427
CHILD_PIDS=()

cleanup() {
local sig="${1:-TERM}"
echo "[entrypoint] Received SIG${sig}, forwarding to child processes" >&2
for pid in "${CHILD_PIDS[@]}"; do
if kill -0 "$pid" 2>/dev/null; then
kill "-${sig}" "$pid" 2>/dev/null || true
fi
done
# Wait for children to exit; ignore errors from already-exited processes
# shellcheck disable=SC2046
wait $(printf '%s ' "${CHILD_PIDS[@]}") 2>/dev/null || true
exit 0
}

trap 'cleanup TERM' TERM
trap 'cleanup INT' INT

# ── Main ─────────────────────────────────────────────────────────

echo 'Setting up NemoClaw...' >&2
Expand Down Expand Up @@ -363,10 +387,15 @@ if [ "$(id -u)" -ne 0 ]; then
# Start gateway in background, auto-pair, then wait
nohup "$OPENCLAW" gateway run >/tmp/gateway.log 2>&1 &
GATEWAY_PID=$!
CHILD_PIDS+=("$GATEWAY_PID")
echo "[gateway] openclaw gateway launched (pid $GATEWAY_PID)" >&2
start_auto_pair
print_dashboard_urls
wait "$GATEWAY_PID"
# Wait in a loop: `wait` is interrupted by trapped signals, so re-wait
# until the gateway actually exits.
while kill -0 "$GATEWAY_PID" 2>/dev/null; do
wait "$GATEWAY_PID" || true
done
exit $?
fi

Expand Down Expand Up @@ -425,11 +454,16 @@ fi
# the agent cannot restart the gateway with a tampered config.
nohup gosu gateway "$OPENCLAW" gateway run >/tmp/gateway.log 2>&1 &
GATEWAY_PID=$!
CHILD_PIDS+=("$GATEWAY_PID")
echo "[gateway] openclaw gateway launched as 'gateway' user (pid $GATEWAY_PID)" >&2

start_auto_pair
print_dashboard_urls

# Keep container running by waiting on the gateway process.
# This script is PID 1 (ENTRYPOINT); if it exits, Docker kills all children.
wait "$GATEWAY_PID"
# Wait in a loop: `wait` is interrupted by trapped signals, so re-wait
# until the gateway actually exits.
while kill -0 "$GATEWAY_PID" 2>/dev/null; do
wait "$GATEWAY_PID" || true
done