Skip to content

fix(scripts): add signal handlers to nemoclaw-start.sh#1488

Open
dknos wants to merge 1 commit intoNVIDIA:mainfrom
dknos:fix/start-script-signals-1427
Open

fix(scripts): add signal handlers to nemoclaw-start.sh#1488
dknos wants to merge 1 commit intoNVIDIA:mainfrom
dknos:fix/start-script-signals-1427

Conversation

@dknos
Copy link
Copy Markdown

@dknos dknos commented Apr 5, 2026

Summary

  • Adds SIGTERM/SIGINT trap to nemoclaw-start.sh
  • Forwards signals to child processes to prevent orphaned background jobs on container shutdown
  • Wraps wait in a loop to handle signal interruption (wait returns early when a trap fires)

Test plan

  • Send SIGTERM to the start script and verify child processes are terminated
  • Run shellcheck on the modified script (passes in pre-commit)

Fixes #1427

🤖 Generated with Claude Code

Add SIGTERM/SIGINT trap to forward signals to child processes
and prevent orphaned background jobs on container shutdown.

Fixes NVIDIA#1427

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 5, 2026

Warning

Rate limit exceeded

@dknos has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 44 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 3 minutes and 44 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0736c526-9db2-426e-8a50-fd57350bf793

📥 Commits

Reviewing files that changed from the base of the PR and between c99e3e8 and 6d2d119.

📒 Files selected for processing (1)
  • scripts/nemoclaw-start.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@dknos
Copy link
Copy Markdown
Author

dknos commented Apr 5, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 5, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nemoclaw-start.sh Lacks Signal Handlers — SIGTERM Orphans Child Processes - IssueFinder - SN 05

2 participants