Skip to content

improvement: add rotation icon to rotated secrets in single env display #6053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scott-ray-wilson wants to merge 2 commits into
base: main
Choose a base branch
from
Open

improvement: add rotation icon to rotated secrets in single env display #6053

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
158f218
improvement: add rotation icon to rotated secrets in single env display
scott-ray-wilson Apr 16, 2026
8a1aa3f
fix: only use relative on single env view
scott-ray-wilson Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
GitBranchIcon,
ImportIcon,
KeyIcon,
RefreshCcwIcon
RefreshCcwIcon,
RefreshCwIcon
} from "lucide-react";
import { twMerge } from "tailwind-merge";

Expand Down Expand Up @@ -221,13 +222,13 @@
className={twMerge("group hover:z-10", pendingActionRowClass(singleEnvPendingAction))}
>
<UnstableTableCell
className={twMerge(
!isSingleEnvView && "sticky left-0 z-10",
!singleEnvPendingAction &&
"bg-container transition-colors duration-75 group-hover:bg-container-hover",
"relative bg-container transition-colors duration-75 group-hover:bg-container-hover",
Comment thread
scott-ray-wilson marked this conversation as resolved.
Outdated
!isSingleEnvView && isFormExpanded && "border-b-0 bg-container-hover",
isSingleEnvView && singleEnvShowOverride && "border-b-border/50",
isSingleEnvView && "pt-3 align-top",

Check failure on line 231 in frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx

View check run for this annotation

Claude / Claude Code Review

RefreshCwIcon absolute positioning breaks when pending action is set 

The `relative` class on the icon cell is gated behind `\!singleEnvPendingAction`, so when a rotated secret has a pending action the cell loses its positioning context while the `RefreshCwIcon` with `absolute right-2 bottom-2` still renders, causing the badge to escape the cell and anchor to a distant ancestor. Fix by applying `relative` unconditionally, separate from the pending-action background classes.
Comment thread
scott-ray-wilson marked this conversation as resolved.
Outdated
pendingActionBorderClass(singleEnvPendingAction)
)}
>
Expand Down Expand Up @@ -256,14 +257,25 @@
)}
/>
) : (
<KeyIcon
className={twMerge(
"block text-secret",
!isSelectionDisabled && "group-hover:!hidden",
isSelected && "!hidden"
<>
<KeyIcon
className={twMerge(
"block text-secret",
!isSelectionDisabled && "group-hover:!hidden",
isSelected && "!hidden"
)}
/>
{singleEnvSecret?.isRotatedSecret && isSingleEnvView && (
<RefreshCwIcon
className={twMerge(
"absolute right-2 bottom-2 !size-2.5 text-secret-rotation",
!isSelectionDisabled && "group-hover:!hidden",
isSelected && "!hidden"
)}
/>
)}
/>
</>
)}

Check warning on line 278 in frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx

View check run for this annotation

Claude / Claude Code Review

RefreshCwIcon missing tooltip in single-env view 

The new RefreshCwIcon rotation badge in the single-env view (lines 269-278) has no Tooltip wrapper, while the equivalent RefreshCcwIcon in the multi-env expanded view is wrapped in a Tooltip with 'Rotated secret' text. Users encountering the tiny 10px absolute-positioned badge in single-env view receive no explanation of what the icon means.
Comment thread
scott-ray-wilson marked this conversation as resolved.
</UnstableTableCell>
{isSingleEnvView ? (
<SecretEditTableRow
Expand Down
Loading