improvement: add rotation icon to rotated secrets in single env display #6053
+20
−8
Claude / Claude Code Review
completed
Apr 16, 2026 in 6m 37s
Code review found 1 important issue
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx:225-231 |
RefreshCwIcon absolute positioning breaks when pending action is set |
| 🟡 Nit | frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx:269-278 |
RefreshCwIcon missing tooltip in single-env view |
Annotations
claude / Claude Code Review
RefreshCwIcon absolute positioning breaks when pending action is set
The `relative` class on the icon cell is gated behind `\!singleEnvPendingAction`, so when a rotated secret has a pending action the cell loses its positioning context while the `RefreshCwIcon` with `absolute right-2 bottom-2` still renders, causing the badge to escape the cell and anchor to a distant ancestor. Fix by applying `relative` unconditionally, separate from the pending-action background classes.
claude / Claude Code Review
RefreshCwIcon missing tooltip in single-env view
The new RefreshCwIcon rotation badge in the single-env view (lines 269-278) has no Tooltip wrapper, while the equivalent RefreshCcwIcon in the multi-env expanded view is wrapped in a Tooltip with 'Rotated secret' text. Users encountering the tiny 10px absolute-positioned badge in single-env view receive no explanation of what the icon means.
Loading