-
Notifications
You must be signed in to change notification settings - Fork 667
DataGrid - Native horizontal scrollbar is temporarily shown when clicking cells in batch/cell mode if focused row and column fixing features are enabled (T1310336) #33374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 26_1
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,7 @@ import type { ValidatingController } from '@ts/grids/grid_core/validating/m_vali | |
|
|
||
| import type { ColumnsController } from '../columns_controller/m_columns_controller'; | ||
| import type { EditingController } from '../editing/m_editing'; | ||
| import { isDataRow } from '../keyboard_navigation/utils'; | ||
| import type { ViewController } from '../m_modules'; | ||
| import modules from '../m_modules'; | ||
| import type { Module, ModuleType } from '../m_types'; | ||
|
|
@@ -233,13 +234,14 @@ export class EditorFactory extends ViewControllerWithMixin { | |
| } else if ($element.length) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can’t the isDataRow check be moved into this condition? |
||
| // align "right bottom" for Mozilla | ||
| const align = browser.mozilla ? 'right bottom' : 'left top'; | ||
| const isDataRowElement = isDataRow($element); | ||
| const isFocusedCellInvalid = $element.hasClass(this.addWidgetPrefix(CELL_INVALID_CLASS)); | ||
| const isFocusedCellModified = $element.hasClass(CELL_MODIFIED_CLASS) && !isFocusedCellInvalid; | ||
| const $content = this.getFocusOverlayContainer($element); | ||
| const focusOverlaySize = this.getFocusOverlaySize($element); | ||
|
|
||
| this._$focusOverlay | ||
| .removeClass(DX_HIDDEN) | ||
| .toggleClass(DX_HIDDEN, isDataRowElement) | ||
| .toggleClass(FOCUSED_CELL_INVALID_CLASS, isFocusedCellInvalid) | ||
|
markallenramirez marked this conversation as resolved.
|
||
| .toggleClass(FOCUSED_CELL_MODIFIED_CLASS, isFocusedCellModified) | ||
| .appendTo($content); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -726,9 +726,10 @@ const editorFactory = (Base: ModuleType<EditorFactory>) => class EditorFactorySt | |
| $element, | ||
| this.addWidgetPrefix.bind(this), | ||
| ); | ||
| const isGroupRow = isGroupRowElement($element); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You also need to add a check for the group footer row. For master/adaptive detail rows, I’ve checked — everything seems fine there. Please make sure to verify this as well. |
||
|
|
||
| return { | ||
| width: elementRect.right - elementRect.left + (isLastCell || isFixedCell ? 0 : 1), | ||
| width: elementRect.right - elementRect.left + (isLastCell || isFixedCell || isGroupRow ? 0 : 1), | ||
| height: elementRect.bottom - elementRect.top, | ||
|
markallenramirez marked this conversation as resolved.
|
||
| }; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment: Could we move this into the DataGrid helpers? For example, into domUtils?