DataGrid - Native horizontal scrollbar is temporarily shown when clicking cells in batch/cell mode if focused row and column fixing features are enabled (T1310336)#33374
Open
markallenramirez wants to merge 2 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a DataGrid UI regression where a native horizontal scrollbar briefly appears when interacting with cells in batch/cell editing mode while focused row and column fixing (sticky columns) are enabled.
Changes:
- Adjusts focus overlay sizing under sticky columns to avoid the 1px width expansion for group rows.
- Hides the focus overlay when the focused element is a data row (
tr.dx-data-row) to prevent transient overflow that can trigger a native horizontal scrollbar.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/sticky_columns/m_sticky_columns.ts | Tweaks focus overlay width calculation in sticky columns mode to avoid an extra pixel for group rows. |
| packages/devextreme/js/__internal/grids/grid_core/editor_factory/m_editor_factory.ts | Updates focus overlay rendering to keep it hidden when focus is on a data row element, reducing overflow/scrollbar flicker risk. |
markallenramirez
force-pushed
the
bug_T1310336/26_1
branch
from
16565fa to
4a689ee
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
packages/devextreme/js/__internal/grids/grid_core/editor_factory/m_editor_factory.ts:250
- When
isDataRowElementis true, the focus overlay is being hidden, but the method still appends the overlay to the DOM, resizes it, and runs positioning calculations. This extra work is unnecessary and can cause avoidable layout/paint work; consider early-returning (or skipping size/position setup) when the overlay should remain hidden for data rows, similar to the existingisHideBorderbranch.
const align = browser.mozilla ? 'right bottom' : 'left top';
const isDataRowElement = isDataRow($element);
const isFocusedCellInvalid = $element.hasClass(this.addWidgetPrefix(CELL_INVALID_CLASS));
const isFocusedCellModified = $element.hasClass(CELL_MODIFIED_CLASS) && !isFocusedCellInvalid;
const $content = this.getFocusOverlayContainer($element);
const focusOverlaySize = this.getFocusOverlaySize($element);
this._$focusOverlay
.toggleClass(DX_HIDDEN, isDataRowElement)
.toggleClass(FOCUSED_CELL_INVALID_CLASS, isFocusedCellInvalid)
.toggleClass(FOCUSED_CELL_MODIFIED_CLASS, isFocusedCellModified)
.appendTo($content);
setOuterHeight(this._$focusOverlay, focusOverlaySize.height);
setOuterWidth(this._$focusOverlay, focusOverlaySize.width);
Alyar666
requested changes
Apr 28, 2026
| @@ -233,13 +234,14 @@ export class EditorFactory extends ViewControllerWithMixin { | |||
| } else if ($element.length) { | |||
Contributor
There was a problem hiding this comment.
Can’t the isDataRow check be moved into this condition?
| $element, | ||
| this.addWidgetPrefix.bind(this), | ||
| ); | ||
| const isGroupRow = isGroupRowElement($element); |
Contributor
There was a problem hiding this comment.
You also need to add a check for the group footer row.
For master/adaptive detail rows, I’ve checked — everything seems fine there. Please make sure to verify this as well.
| const firstGroupRow = dataGrid.getGroupRow(0); | ||
| const firstDataRow = dataGrid.getDataRow(1); | ||
| const secondDataCell = firstDataRow.getDataCell(2); | ||
| const hasHorizontalScroll = async () => { |
Contributor
There was a problem hiding this comment.
Minor comment: Could we move this into the DataGrid helpers? For example, into domUtils?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.