Skip to content

Fix decimal.Decimal serialization in process_record #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yotamobol wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

Fix decimal.Decimal serialization in process_record #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion target_gcs/sinks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
from io import FileIO
from typing import Optional

import decimal

import orjson
import smart_open
from google.cloud.storage import Client
Expand Down Expand Up @@ -82,5 +84,16 @@ def process_record(self, record: dict, context: dict) -> None:
passed `context` dict from the current batch.
"""
self.gcs_write_handle.write(
orjson.dumps(record, option=orjson.OPT_APPEND_NEWLINE)
orjson.dumps(
record,
option=orjson.OPT_APPEND_NEWLINE,
default=_default_serializer,
)
)


def _default_serializer(obj):
"""Handle types that orjson cannot serialize natively."""
if isinstance(obj, decimal.Decimal):
return float(obj)
raise TypeError(f"Type is not JSON serializable: {type(obj)}")