Fix decimal.Decimal serialization in process_record#73
Open
yotamobol wants to merge 1 commit intoDatateer:mainfrom
Open
Fix decimal.Decimal serialization in process_record#73yotamobol wants to merge 1 commit intoDatateer:mainfrom
yotamobol wants to merge 1 commit intoDatateer:mainfrom
Conversation
singer-sdk 0.40+ passes decimal.Decimal values in records for numeric fields. orjson.dumps() does not natively handle Decimal, causing a TypeError crash. Add a default serializer that converts Decimal to float. Fixes Datateer#72 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
@frctnlss can you please take a look? |
Author
|
@aroder can you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultserializer toorjson.dumps()inGCSSink.process_recordto handledecimal.Decimalvalues by converting them tofloatsinger-sdk0.40+ passesDecimalfor numeric fields (for precision), butorjsoncannot serialize them nativelyFixes #72
Test plan
decimal.Decimalvalues (e.g. account balances)TypeError🤖 Generated with Claude Code