-
Notifications
You must be signed in to change notification settings - Fork 6
Log in feature #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Odeane
wants to merge
17
commits into
CraftAcademy:master
Choose a base branch
from
Odeane:log_in_feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6913aac
fixing gem bug, creating rspec folder and creating db migration to co…
Odeane c1720bd
installing Rspec, creating a database, updating migration version, ap…
Alex-Bellamy 76f7174
created a specfolder and updated the db migration version to 4.2 and …
2583dc9
login functionality - adding test to ensure Login button is present a…
Alex-Bellamy 2368b8d
wrote teo new tests for log in feature, first i changed root_path to …
62fbc43
writing test for redirecting efter log in
d3d1558
updated README
83b73b6
testing setup
Odeane d909ed5
setting up factor bot, adding shoulder matcher
Odeane 02562d0
Merge branch 'log_in_feature' of https://github.com/Odeane/legacy_cod…
Alex-Bellamy e637ffb
amending Factorybot password to enable tests to pass
Alex-Bellamy a38bda3
rewrote test to actually display that the login was succsessful
4dab8ae
sad path for not entering or entering incorrect password
Odeane b2da6c7
adding coveralls
Odeane 8abaa3f
resolving text formatting and writing a more realistic sad path
Odeane 3e8ec4a
testing sad path seperately
Odeane 22bcf67
formatting
Odeane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ | |
| !/log/.keep | ||
| /tmp | ||
| .byebug_history | ||
|
|
||
| .coverage/ | ||
|
|
||
| # OSX files | ||
| .DS_Store | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| --require spec_helper | ||
| --color | ||
| --format documentation | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| ## CA Mailboxer 2018 | ||
|
|
||
| Code base for week 5 challenge - Working with legacy code | ||
| Code base for week 5 challenge - Working with legacy code... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "result": { | ||
| "covered_percent": 34.09 | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.