Open
Conversation
…p now loads on server
…created a db migartion for add_missing_indices.mailboxer_engine
…nd the button functions which pass
…user_session_path then wrote test to locate Email to make sure i was in the right path second test was for filling in email, password and then clickon log in button
emtalen
requested changes
Jun 25, 2020
emtalen
left a comment
emtalen
left a comment
There was a problem hiding this comment.
Good jobb overall, look over the formatting! And rewrite the sad path to a more realistic scenario, that a user puts in the wrong password for example.
| end | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove this file if you are not using it.
emtalen
requested changes
Jun 26, 2020
emtalen
left a comment
emtalen
left a comment
There was a problem hiding this comment.
You still have some formatting to do, I recommend that you install a Ruby formatter so you can have a shortcut to formatting. I use Solargraph but you guys can just search for a formatter in the extensions to find one you like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PT board URL
User Story
Changes proposed in this pull request:
What I have learned working on this feature:
Packages/Gems added