Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Add response header outcomes#176

Open
erikwebb wants to merge 1 commit intoBehat:masterfrom
erikwebb:header-outcomes
Open

Add response header outcomes#176
erikwebb wants to merge 1 commit intoBehat:masterfrom
erikwebb:header-outcomes

Conversation

@erikwebb
Copy link
Copy Markdown

@stof
Copy link
Copy Markdown
Member

stof commented Jan 23, 2015

This Mink PR has been replaced with minkphp/Mink#636

@aik099
Copy link
Copy Markdown

aik099 commented Jan 23, 2015

Are you sure? The minkphp/Mink#636 is adding methods to WebAssert class in Mink that are then used by this PR to add new methods to MinkContext.

@stof
Copy link
Copy Markdown
Member

stof commented Jan 23, 2015

There is a typo in my previous comment. It should have been The Mink PR, not This Mink PR

@aik099
Copy link
Copy Markdown

aik099 commented Jan 23, 2015

Maybe you should just close the PR is we're no longer plan to continue work on it?

@stof
Copy link
Copy Markdown
Member

stof commented Jan 23, 2015

Well, this PR is not obsolete. It exposes the new assertions to the Behat land

@aik099
Copy link
Copy Markdown

aik099 commented Jan 23, 2015

Then your comment should say this to be 100% clear:

The Mink's PR mentioned in task description was replaced by minkphp/Mink#636.

@stof
Copy link
Copy Markdown
Member

stof commented Feb 4, 2015

The Mink PR has been merged. the feature is now in Mink 1.7.x-dev. I will wait a bit with this PR to avoid forcing to use a dev version of Mink in the extension.

@danielbachhuber
Copy link
Copy Markdown

@stof Anything I can do to help this land?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants