Add steps and basic tests for response headers#37
Merged
danielbachhuber merged 5 commits intomasterfrom Oct 31, 2016
Merged
Conversation
stevector
reviewed
Oct 31, 2016
| Scenario: Cache-Control should default to TTL=600 | ||
| When I go to "/" | ||
| Then the response header "Cache-Control" should exist | ||
| And the response header "Cache-Control" should contain "max-age=600" |
Collaborator
There was a problem hiding this comment.
Is there a reason to test only max-age and not
And the response header "Cache-Control" should be "public, max-age=600"
Contributor
Author
There was a problem hiding this comment.
Not necessarily. I've made it more precise in d4009cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Behat/MinkExtension#176