Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,7 @@ input DatasetExampleInput {
output: JSON!
metadata: JSON!
spanId: ID
externalId: String
}

input DatasetExamplePatch {
Expand Down
2 changes: 1 addition & 1 deletion app/src/Routes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ import { PromptVersionDetailsPage } from "./pages/prompt/PromptVersionDetailsPag
import { promptVersionLoader } from "./pages/prompt/promptVersionLoader";
import { promptVersionsLoader } from "./pages/prompt/promptVersionsLoader";
import { PromptVersionsPage } from "./pages/prompt/PromptVersionsPage";
import { projectRedirectLoader } from "./pages/redirects/projectRedirectLoader";
import { exampleRedirectLoader } from "./pages/redirects/exampleRedirectLoader";
import { projectRedirectLoader } from "./pages/redirects/projectRedirectLoader";
import { promptTagRedirectLoader } from "./pages/redirects/promptTagRedirectLoader";
import { sessionRedirectLoader } from "./pages/redirects/sessionRedirectLoader";
import { spanRedirectLoader } from "./pages/redirects/spanRedirectLoader";
Expand Down
99 changes: 87 additions & 12 deletions app/src/pages/dataset/AddDatasetExampleButton.tsx
Original file line number Diff line number Diff line change
@@ -1,40 +1,115 @@
import { css } from "@emotion/react";
import { useCallback, useState } from "react";

import {
Button,
Dialog,
DialogCloseButton,
DialogContent,
DialogHeader,
DialogTitle,
DialogTitleExtra,
DialogTrigger,
Icon,
Icons,
Modal,
ModalOverlay,
Tab,
TabList,
TabPanel,
Tabs,
} from "@phoenix/components";
import { DatasetFromFileForm } from "@phoenix/pages/datasets/DatasetFromFileForm";

import { AddExampleFromScratchForm } from "./AddExampleFromScratchForm";

const dialogCSS = css`
display: flex;
flex-direction: column;
flex: 1 1 auto;
height: 100%;
`;

const contentCSS = css`
height: auto;
flex: 1 1 auto;
min-height: 0;
`;

import { AddDatasetExampleDialog } from "./AddDatasetExampleDialog";
const tabPanelCSS = css`
flex: 1;
min-height: 0;
`;

type AddDatasetExampleButtonProps = {
datasetId: string;
datasetName: string;
onAddExampleCompleted: () => void;
};

export function AddDatasetExampleButton(props: AddDatasetExampleButtonProps) {
const { datasetId, onAddExampleCompleted } = props;
const { datasetId, datasetName, onAddExampleCompleted } = props;
const [isOpen, setIsOpen] = useState(false);

const handleCompleted = useCallback(() => {
onAddExampleCompleted();
}, [onAddExampleCompleted]);

const handleFileCompleted = useCallback(() => {
onAddExampleCompleted();
setIsOpen(false);
}, [onAddExampleCompleted]);

const handleCancel = useCallback(() => setIsOpen(false), []);

return (
<DialogTrigger>
<DialogTrigger onOpenChange={setIsOpen} isOpen={isOpen}>
<Button
leadingVisual={<Icon svg={<Icons.PlusOutline />} />}
size="M"
aria-label="Add Dataset Example"
variant="primary"
onPress={() => setIsOpen(true)}
>
Example
Examples
</Button>
<ModalOverlay>
<Modal size="L">
<AddDatasetExampleDialog
datasetId={datasetId}
onCompleted={() => {
onAddExampleCompleted();
}}
/>
<ModalOverlay isOpen={isOpen} onOpenChange={setIsOpen}>
<Modal variant="slideover" size="fullscreen">
<Dialog css={dialogCSS}>
{({ close }) => (
<>
<DialogHeader>
<DialogTitle>Add Examples</DialogTitle>
<DialogTitleExtra>
<DialogCloseButton slot="close" />
</DialogTitleExtra>
</DialogHeader>
<DialogContent css={contentCSS}>
<Tabs>
<TabList>
<Tab id="fromFile">From file</Tab>
<Tab id="fromScratch">From scratch</Tab>
</TabList>
<TabPanel id="fromFile" css={tabPanelCSS}>
<DatasetFromFileForm
mode="append"
datasetName={datasetName}
onExamplesAdded={handleFileCompleted}
onCancel={handleCancel}
/>
</TabPanel>
<TabPanel id="fromScratch">
<AddExampleFromScratchForm
datasetId={datasetId}
onExampleAdded={handleCompleted}
close={close}
/>
</TabPanel>
</Tabs>
</DialogContent>
</>
)}
</Dialog>
</Modal>
</ModalOverlay>
</DialogTrigger>
Expand Down
Loading
Loading