feat(datasets): dataset upsert ui#12497
Draft
axiomofjoy wants to merge 21 commits intofeat/dataset-upsertfrom
Draft
feat(datasets): dataset upsert ui#12497axiomofjoy wants to merge 21 commits intofeat/dataset-upsertfrom
axiomofjoy wants to merge 21 commits intofeat/dataset-upsertfrom
Conversation
dosubot
bot
added
the
size:M
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
dosubot
bot
added
size:L
axiomofjoy
force-pushed
the
feat/dataset-upsert
branch
from
ab4f516 to
9f31832
Compare
axiomofjoy
force-pushed
the
xander/dataset-roundtripping
branch
from
ed9c932 to
48b7e31
Compare
@arizeai/phoenix-cli
@arizeai/phoenix-client
@arizeai/phoenix-evals
@arizeai/phoenix-mcp
@arizeai/phoenix-otel
commit: |
axiomofjoy
changed the title
axiomofjoy
force-pushed
the
feat/dataset-upsert
branch
from
9f31832 to
c8312d3
Compare
axiomofjoy
force-pushed
the
xander/dataset-roundtripping
branch
from
e5fbbd0 to
157d8a3
Compare
… _get_dataset_example_revisions Separate concerns so each helper does one thing. Callers now handle GlobalID parsing inline and invoke the two helpers independently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
axiomofjoy
force-pushed
the
xander/dataset-roundtripping
branch
from
157d8a3 to
f9765b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_db_examplesinto two focused helpers:_get_dataset_nameand_get_dataset_example_revisionsintIDs, making them independently reusableget_dataset_csv,get_dataset_jsonl_openai_ft,get_dataset_jsonl_openai_evals) handle GlobalID parsing inlineTest plan
test_get_dataset_download_*,test_get_dataset_jsonl_*)🤖 Generated with Claude Code