Skip to content

fix: avoid unbound variable errors for NO_CHANGELOG_LABEL and BASE_REF #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ocheretovich wants to merge 3 commits into
base: next
Choose a base branch
from
Open

fix: avoid unbound variable errors for NO_CHANGELOG_LABEL and BASE_REF #3009

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccbd4ee
fix: avoid unbound variable errors for NO_CHANGELOG_LABEL and BASE_REF
Ocheretovich Apr 16, 2026
4b497be
fix: check BASE_REF only when needed
Ocheretovich Apr 20, 2026
218bdd5
Merge branch 'next' into patch-1
Ocheretovich Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/check-changelog.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
#!/bin/bash
set -uo pipefail

: "${BASE_REF:?BASE_REF is not set}"
Comment thread
Ocheretovich marked this conversation as resolved.
Outdated

CHANGELOG_FILE="${1:-CHANGELOG.md}"

if [ "${NO_CHANGELOG_LABEL}" = "true" ]; then
if [ "${NO_CHANGELOG_LABEL:-false}" = "true" ]; then
# 'no changelog' set, so finish successfully
echo "\"no changelog\" label has been set"
exit 0
Expand Down
Loading