Skip to content

fix: avoid unbound variable errors for NO_CHANGELOG_LABEL and BASE_REF#3009

Open
Ocheretovich wants to merge 3 commits into0xMiden:nextfrom
Ocheretovich:patch-1
Open

fix: avoid unbound variable errors for NO_CHANGELOG_LABEL and BASE_REF#3009
Ocheretovich wants to merge 3 commits into0xMiden:nextfrom
Ocheretovich:patch-1

Conversation

@Ocheretovich
Copy link
Copy Markdown

@Ocheretovich Ocheretovich commented Apr 16, 2026

Rationale: With set -u, if NO_CHANGELOG_LABEL=true and BASE_REF is not set, the script was failing before the early return could exit successfully. Moving the BASE_REF check below the early return fixes this.

Copy link
Copy Markdown
Collaborator

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BASE_REF is now required before checking NO_CHANGELOG_LABEL, so a run with
NO_CHANGELOG_LABEL=true and no BASE_REF will fail instead of taking the intended successful early exit for “no changelog” PRs.

Comment thread scripts/check-changelog.sh Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

Automated check (CONTRIBUTING.md)

Findings:

Recommendations:

  • Consider adding a Test plan or clear review steps.

Next steps:

  • Link a relevant issue (e.g., "Fixes Implement SHA256 in Miden Assembly #123") and ensure it is assigned to you.
  • See CONTRIBUTING.md for expectations.
  • If this is a false positive, comment: /quality-review.

@Ocheretovich Ocheretovich requested a review from huitseeker April 20, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants