fix: avoid unbound variable errors for NO_CHANGELOG_LABEL and BASE_REF#3009
Open
Ocheretovich wants to merge 3 commits into0xMiden:nextfrom
Open
fix: avoid unbound variable errors for NO_CHANGELOG_LABEL and BASE_REF#3009Ocheretovich wants to merge 3 commits into0xMiden:nextfrom
Ocheretovich wants to merge 3 commits into0xMiden:nextfrom
Conversation
huitseeker
requested changes
Apr 17, 2026
Collaborator
huitseeker
left a comment
There was a problem hiding this comment.
BASE_REF is now required before checking NO_CHANGELOG_LABEL, so a run with
NO_CHANGELOG_LABEL=true and no BASE_REF will fail instead of taking the intended successful early exit for “no changelog” PRs.
|
Automated check (CONTRIBUTING.md) Findings:
Recommendations:
Next steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: With set -u, if NO_CHANGELOG_LABEL=true and BASE_REF is not set, the script was failing before the early return could exit successfully. Moving the BASE_REF check below the early return fixes this.