refactor: replace direct indexing for bus_prefix and beta_powers#2965
refactor: replace direct indexing for bus_prefix and beta_powers#2965
bus_prefix and beta_powers#2965Conversation
a9ad7e7 to
8630cbe
Compare
|
I haven't taken a full look yet, but this is looking very nice! It should play nicely into #2962. During the exploration of the tradeoff between trace generation and constraint evaluation, it became clear that we needed an extension point for groups of messages (e.g. Hasher and BlockHash). These groups have many mutually exclusive flags with ~7 possible messages, all sharing a very common structure. The naive constraint evaluation algorithm would encode each message individually, and some rough estimates showed this would double the number of EF operations. The ideas being explored in the PR involve adding a hook for InteractionGroup which allows the caller to specialize the computation of the messages, caching common sub expressions. This requires direct access to the challenges, so this PR definitely helps with getting those correct. |
|
After merging next into adr1anh/constraint-simplification, I'll cherry pick this into #2856 |
Describe your changes
Match AIR trace access for clarity and safety upon updating / tweaking hardcoded constants.
LMK what you think @adr1anh, feel free to close if you think that's not appropriate
Checklist before requesting a review
nextaccording to naming convention.