Conversation
✅ Deploy Preview for zmk-studio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| edition = "2021" | ||
| rust-version = "1.60" | ||
| edition = "2024" | ||
| rust-version = "1.91.1" |
There was a problem hiding this comment.
MSRV was not real before (for instance, tokio 1.37 had MSRV of 1.63) thus bumped it to pre-latest version of Rust
I don't think that there is a good reason to stick to older version given that this is a binary and not a library, but feel free to request downgrading
| default-run = "app" | ||
| edition = "2021" | ||
| rust-version = "1.60" | ||
| edition = "2024" |
There was a problem hiding this comment.
Same as with MSRV, no readon to keep it old, but ready to downgrade it
| const __dirname = path.resolve(__filename, "../.."); | ||
|
|
||
| async function generateReleaseData() { | ||
| async function generateReleaseData(version) { |
There was a problem hiding this comment.
Doing HTTP call (every time) just to build the binary every time is quite painful for any distribution (since builds may only pre-fetch locked libraries and then perform the build in isolation) thus switched to explicitly passing the version here and statically generating metadata.
This also provides determinism (builds should not differ on the time of the build, which currently is possible since to latest being volatile) and lets the specific branch/tag be built with the correct version in generated file.
|
Hi, @petejohanson, @Nicell, apologies for pinging Could you please take a look at this PR? |
1 participant
While packaging
zmk-studiofor nixpkgs I've encountered a number of errors which are fixed in this PR:major.minortauri version does not match it in the lock-file: updated version.PhysicalLayoutPicker.tsxfails type-check due to unhandlednull: declared explicit nullability.This PR is based on
0.3.1releaseThe resulting PR successfully builds using nix: