Conversation
✅ Deploy Preview for zmk-studio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Nicell
left a comment
There was a problem hiding this comment.
Considering this file is generated from a generated file from the USB-IF, we probably don't want to edit it directly. Can you add these changes to the override file instead? I agree that these names are not as accurate, but they do come from the USB HID tables https://usb.org/document-library/hid-usage-tables-15
|
@Nicell - is https://github.com/zmkfirmware/zmk-studio/blob/main/src/HidUsageTables-1.5.json the dump from USB-IF? I had a read through the PDF spec and it's just got the literal symbols, but if that's the correct source I might have a look through it and see if there's other things where they've made a decision to name a symbol in a way that might not be ideal. |
The PDF spec has that file as an attachment in the PDF (a feature I didn't know existed before finding it). You want to add overrides to https://github.com/zmkfirmware/zmk-studio/blob/main/src%2Fhid-usage-name-overrides.json instead. |
|
omg... it's in the pdf?? I've been doing a scan through and can't find it but given that i didn't even think to look there I'm not surprised if my brain just doesn't work in the same way. (i'll go and do a PR in a bit, found one that I hit around Return and Return Enter 😑 ) |
resolves #100