Skip to content

Fix DEADLINE_EXCEEDED gRPC timeout on Zilliz Serverless #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alfredsgenkins wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix DEADLINE_EXCEEDED gRPC timeout on Zilliz Serverless #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 5 additions & 30 deletions packages/core/src/vectordb/milvus-vectordb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ export class MilvusVectorDatabase implements VectorDatabase {
private async initializeClient(address: string): Promise<void> {
const milvusConfig = this.config as MilvusConfig;
console.log('🔌 Connecting to vector database at: ', address);
const timeoutMs = Number(process.env.MILVUS_TIMEOUT_MS) || 60000;
this.client = new MilvusClient({
address: address,
username: milvusConfig.username,
password: milvusConfig.password,
token: milvusConfig.token,
ssl: milvusConfig.ssl || false,
timeout: timeoutMs,
});
}

Expand Down Expand Up @@ -742,42 +744,15 @@ export class MilvusVectorDatabase implements VectorDatabase {
throw new Error('MilvusClient is not initialized. Call ensureInitialized() first.');
}

const collectionName = `dummy_collection_${Date.now()}`;
const createCollectionParams = {
collection_name: collectionName,
description: 'Test collection for limit check',
fields: [
{
name: 'id',
data_type: DataType.VarChar,
max_length: 512,
is_primary_key: true,
},
{
name: 'vector',
data_type: DataType.FloatVector,
dim: 128,
}
]
};

try {
await this.client.createCollection(createCollectionParams);
// Immediately drop the collection after successful creation
if (await this.client.hasCollection({ collection_name: collectionName })) {
await this.client.dropCollection({
collection_name: collectionName,
});
}
return true;
const response = await this.client.listCollections();
const maxCollections = Number(process.env.MILVUS_MAX_COLLECTIONS) || 4;
return response.data.length < maxCollections;
} catch (error: any) {
// Check if the error message contains the collection limit exceeded pattern
const errorMessage = error.message || error.toString() || '';
if (/exceeded the limit number of collections/i.test(errorMessage)) {
// Return false for collection limit exceeded
return false;
}
// Re-throw other errors as-is
throw error;
}
}
Expand Down