feat(api): optimize api rate limiting and fix token/semaphore leaks#11
Open
feat(api): optimize api rate limiting and fix token/semaphore leaks#11
Conversation
Core changes: - GlobalRateLimiter: check IP quota before global QPS so per-IP rejections do not consume a global token; reorder to ip-first - RateLimiterServlet.service: check per-endpoint limiter before global to avoid wasting global IP/QPS quota on requests that will be rejected anyway; track perEndpointAcquired separately so IPreemptibleRateLimiter permits are always released in finally - RateLimiterInterceptor.interceptCall: same ordering fix; add explicit permit release in the early-return path (global rejects after per-endpoint acquired) and in the catch block when next.startCall() throws, preventing a permanent semaphore leak that would eventually block all gRPC requests - GlobalPreemptibleStrategy: remove unused timeout constant and @slf4j annotation Tests: - GlobalRateLimiterTest: verify ip-first ordering conserves global tokens; cover no-ip fallback and independent per-ip limits - RateLimiterServletTest: verify per-endpoint rejection skips global; permit released on global rejection and on normal completion - RateLimiterInterceptorTest: verify per-endpoint rejection skips global; permit released on global rejection, on startCall exception, and via listener onComplete/onCancel - AdaptorTest: minor cleanup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core changes:
Tests:
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details