Skip to content

Added find blocks function and a check if bot is placing a block where it is standing#250

Merged
demid-ns merged 5 commits intoyuniko-software:mainfrom
agrofx1:main
Apr 4, 2026
Merged

Added find blocks function and a check if bot is placing a block where it is standing#250
demid-ns merged 5 commits intoyuniko-software:mainfrom
agrofx1:main

Conversation

@agrofx1
Copy link
Copy Markdown
Contributor

@agrofx1 agrofx1 commented Mar 5, 2026

Changes:

  • Added a find-blocks function that enables the LLM to know it surroundings
  • Added a check if LLM is placing a block where it is standing

  • I have read and am familiar with CONTRIBUTING.md
    I commited in a main branch because it is a small change

@agrofx1
Copy link
Copy Markdown
Contributor Author

agrofx1 commented Mar 9, 2026

@demid-ns, can you check my pr?

@demid-ns
Copy link
Copy Markdown
Member

demid-ns commented Mar 9, 2026

@demid-ns, can you check my pr?

Yes, I will in next few days

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Minecraft MCP server’s block interaction tools to (1) prevent the bot from placing blocks in its own occupied space, and (2) expand the block-finding capability to optionally return multiple nearby matches.

Changes:

  • Added a self-placement guard to place-block (blocks placing at the bot’s feet and the block above).
  • Renamed find-block to find-blocks and added optional count support for returning multiple block positions.
  • Updated tests and README command list to reflect the new tool name and behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/tools/block-tools.ts Adds place-block self-placement check; renames and extends find-block tool to support multiple results.
tests/block-tools.test.ts Updates tool registration expectations; adds coverage for self-placement guard and multi-result find-blocks.
README.md Updates available command list from find-block to find-blocks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tools/block-tools.ts
Comment thread src/tools/block-tools.ts
Comment thread src/tools/block-tools.ts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tools/block-tools.ts Outdated
Comment thread src/tools/block-tools.ts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tools/block-tools.ts
@demid-ns
Copy link
Copy Markdown
Member

demid-ns commented Apr 4, 2026

Hey @agrofx1 thanks for the contribution. I apologise that the review took so much time

@demid-ns demid-ns merged commit 240c8ce into yuniko-software:main Apr 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants