Rename xz crate to xz-core#7
Conversation
WalkthroughRenamed the workspace crate Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRsPoem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/inspect_codegen.sh (1)
9-9:⚠️ Potential issue | 🟡 MinorUpdate the documented default package.
Line 33 now defaults to
xz-core, but Line 9 still says the default isxz.📝 Proposed fix
- --package <name> Cargo package to inspect (default: xz) + --package <name> Cargo package to inspect (default: xz-core)Also applies to: 33-33
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/inspect_codegen.sh` at line 9, The help text for the --package option in scripts/inspect_codegen.sh is out of sync: update the documented default package string from "xz" to "xz-core" so it matches the actual default used on line 33; edit the option description that currently reads "--package <name> Cargo package to inspect (default: xz)" to instead state "(default: xz-core)" (locate the help string for the --package flag in the script).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@scripts/inspect_codegen.sh`:
- Line 9: The help text for the --package option in scripts/inspect_codegen.sh
is out of sync: update the documented default package string from "xz" to
"xz-core" so it matches the actual default used on line 33; edit the option
description that currently reads "--package <name> Cargo package to inspect
(default: xz)" to instead state "(default: xz-core)" (locate the help string for
the --package flag in the script).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8f83282e-246f-497e-8057-c6f37f7b499b
📒 Files selected for processing (114)
Cargo.tomlbenches/backend_comparison.rsdocs/performance-workflow.mdexamples/bufread_trailing_probe.rsexamples/qc_probe.rsexamples/standard_files_probe.rsperf-probe/Cargo.tomlperf-probe/src/main.rsscripts/compare_all_trimmed.shscripts/compare_api_workloads.shscripts/compare_backends.shscripts/compare_workloads.shscripts/inspect_codegen.shscripts/profile_backend.shsrc/lib.rssrc/stream.rssystest/build.rstests/sys_equivalence.rsxz-core/Cargo.tomlxz-core/src/alloc.rsxz-core/src/check/check.rsxz-core/src/check/crc32_fast.rsxz-core/src/check/crc64_fast.rsxz-core/src/check/mod.rsxz-core/src/check/sha256.rsxz-core/src/common/alone_decoder.rsxz-core/src/common/alone_encoder.rsxz-core/src/common/auto_decoder.rsxz-core/src/common/block_buffer_decoder.rsxz-core/src/common/block_buffer_encoder.rsxz-core/src/common/block_decoder.rsxz-core/src/common/block_encoder.rsxz-core/src/common/block_header_decoder.rsxz-core/src/common/block_header_encoder.rsxz-core/src/common/block_util.rsxz-core/src/common/common.rsxz-core/src/common/common_types.rsxz-core/src/common/easy_buffer_encoder.rsxz-core/src/common/easy_decoder_memusage.rsxz-core/src/common/easy_encoder.rsxz-core/src/common/easy_encoder_memusage.rsxz-core/src/common/easy_preset.rsxz-core/src/common/file_info.rsxz-core/src/common/filter_buffer_decoder.rsxz-core/src/common/filter_buffer_encoder.rsxz-core/src/common/filter_common.rsxz-core/src/common/filter_decoder.rsxz-core/src/common/filter_encoder.rsxz-core/src/common/filter_flags_decoder.rsxz-core/src/common/filter_flags_encoder.rsxz-core/src/common/hardware_cputhreads.rsxz-core/src/common/hardware_physmem.rsxz-core/src/common/index.rsxz-core/src/common/index_decoder.rsxz-core/src/common/index_encoder.rsxz-core/src/common/index_hash.rsxz-core/src/common/lzip_decoder.rsxz-core/src/common/microlzma_decoder.rsxz-core/src/common/microlzma_encoder.rsxz-core/src/common/mod.rsxz-core/src/common/outqueue.rsxz-core/src/common/stream_buffer_decoder.rsxz-core/src/common/stream_buffer_encoder.rsxz-core/src/common/stream_decoder.rsxz-core/src/common/stream_decoder_mt.rsxz-core/src/common/stream_encoder.rsxz-core/src/common/stream_encoder_mt.rsxz-core/src/common/stream_flags_common.rsxz-core/src/common/stream_flags_decoder.rsxz-core/src/common/stream_flags_encoder.rsxz-core/src/common/stream_mt.rsxz-core/src/common/string_conversion.rsxz-core/src/common/threading.rsxz-core/src/common/vli_decoder.rsxz-core/src/common/vli_encoder.rsxz-core/src/common/vli_size.rsxz-core/src/delta/delta_common.rsxz-core/src/delta/delta_decoder.rsxz-core/src/delta/delta_encoder.rsxz-core/src/delta/mod.rsxz-core/src/lib.rsxz-core/src/lz/lz_decoder.rsxz-core/src/lz/lz_encoder.rsxz-core/src/lz/lz_encoder_mf.rsxz-core/src/lz/mod.rsxz-core/src/lzma/fastpos_table.rsxz-core/src/lzma/lzma2_decoder.rsxz-core/src/lzma/lzma2_encoder.rsxz-core/src/lzma/lzma_decoder.rsxz-core/src/lzma/lzma_encoder.rsxz-core/src/lzma/lzma_encoder_optimum_fast.rsxz-core/src/lzma/lzma_encoder_optimum_normal.rsxz-core/src/lzma/lzma_encoder_presets.rsxz-core/src/lzma/mod.rsxz-core/src/rangecoder/mod.rsxz-core/src/rangecoder/price_table.rsxz-core/src/simple/arm.rsxz-core/src/simple/arm64.rsxz-core/src/simple/armthumb.rsxz-core/src/simple/ia64.rsxz-core/src/simple/mod.rsxz-core/src/simple/powerpc.rsxz-core/src/simple/riscv.rsxz-core/src/simple/simple_coder.rsxz-core/src/simple/simple_decoder.rsxz-core/src/simple/simple_encoder.rsxz-core/src/simple/sparc.rsxz-core/src/simple/x86.rsxz-core/src/tuklib/mod.rsxz-core/src/tuklib/tuklib_cpucores.rsxz-core/src/tuklib/tuklib_physmem.rsxz-core/src/types.rsxz-sys/Cargo.tomlxz-sys/src/lib.rs
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/inspect_codegen.sh (1)
9-9:⚠️ Potential issue | 🟡 MinorStale help text: default package is now
xz-core.Line 33 sets
PACKAGE="xz-core", but the--helpoutput on line 9 still advertises the default asxz. Update the usage string to match.📝 Proposed fix
- --package <name> Cargo package to inspect (default: xz) + --package <name> Cargo package to inspect (default: xz-core)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/inspect_codegen.sh` at line 9, The help text is stale: update the usage string that shows "--package <name> Cargo package to inspect (default: xz)" to reflect the new default PACKAGE="xz-core". Locate the help/usage output in scripts/inspect_codegen.sh (the line printing the --package description) and change the default shown from "xz" to "xz-core"; also scan for any other occurrences of "default: xz" in the script and update them to "default: xz-core".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@scripts/inspect_codegen.sh`:
- Line 9: The help text is stale: update the usage string that shows "--package
<name> Cargo package to inspect (default: xz)" to reflect the new default
PACKAGE="xz-core". Locate the help/usage output in scripts/inspect_codegen.sh
(the line printing the --package description) and change the default shown from
"xz" to "xz-core"; also scan for any other occurrences of "default: xz" in the
script and update them to "default: xz-core".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 708d302e-fdcb-49de-8fe1-493027ad4e92
📒 Files selected for processing (115)
Cargo.lock.msrvCargo.tomlbenches/backend_comparison.rsdocs/performance-workflow.mdexamples/bufread_trailing_probe.rsexamples/qc_probe.rsexamples/standard_files_probe.rsperf-probe/Cargo.tomlperf-probe/src/main.rsscripts/compare_all_trimmed.shscripts/compare_api_workloads.shscripts/compare_backends.shscripts/compare_workloads.shscripts/inspect_codegen.shscripts/profile_backend.shsrc/lib.rssrc/stream.rssystest/build.rstests/sys_equivalence.rsxz-core/Cargo.tomlxz-core/src/alloc.rsxz-core/src/check/check.rsxz-core/src/check/crc32_fast.rsxz-core/src/check/crc64_fast.rsxz-core/src/check/mod.rsxz-core/src/check/sha256.rsxz-core/src/common/alone_decoder.rsxz-core/src/common/alone_encoder.rsxz-core/src/common/auto_decoder.rsxz-core/src/common/block_buffer_decoder.rsxz-core/src/common/block_buffer_encoder.rsxz-core/src/common/block_decoder.rsxz-core/src/common/block_encoder.rsxz-core/src/common/block_header_decoder.rsxz-core/src/common/block_header_encoder.rsxz-core/src/common/block_util.rsxz-core/src/common/common.rsxz-core/src/common/common_types.rsxz-core/src/common/easy_buffer_encoder.rsxz-core/src/common/easy_decoder_memusage.rsxz-core/src/common/easy_encoder.rsxz-core/src/common/easy_encoder_memusage.rsxz-core/src/common/easy_preset.rsxz-core/src/common/file_info.rsxz-core/src/common/filter_buffer_decoder.rsxz-core/src/common/filter_buffer_encoder.rsxz-core/src/common/filter_common.rsxz-core/src/common/filter_decoder.rsxz-core/src/common/filter_encoder.rsxz-core/src/common/filter_flags_decoder.rsxz-core/src/common/filter_flags_encoder.rsxz-core/src/common/hardware_cputhreads.rsxz-core/src/common/hardware_physmem.rsxz-core/src/common/index.rsxz-core/src/common/index_decoder.rsxz-core/src/common/index_encoder.rsxz-core/src/common/index_hash.rsxz-core/src/common/lzip_decoder.rsxz-core/src/common/microlzma_decoder.rsxz-core/src/common/microlzma_encoder.rsxz-core/src/common/mod.rsxz-core/src/common/outqueue.rsxz-core/src/common/stream_buffer_decoder.rsxz-core/src/common/stream_buffer_encoder.rsxz-core/src/common/stream_decoder.rsxz-core/src/common/stream_decoder_mt.rsxz-core/src/common/stream_encoder.rsxz-core/src/common/stream_encoder_mt.rsxz-core/src/common/stream_flags_common.rsxz-core/src/common/stream_flags_decoder.rsxz-core/src/common/stream_flags_encoder.rsxz-core/src/common/stream_mt.rsxz-core/src/common/string_conversion.rsxz-core/src/common/threading.rsxz-core/src/common/vli_decoder.rsxz-core/src/common/vli_encoder.rsxz-core/src/common/vli_size.rsxz-core/src/delta/delta_common.rsxz-core/src/delta/delta_decoder.rsxz-core/src/delta/delta_encoder.rsxz-core/src/delta/mod.rsxz-core/src/lib.rsxz-core/src/lz/lz_decoder.rsxz-core/src/lz/lz_encoder.rsxz-core/src/lz/lz_encoder_mf.rsxz-core/src/lz/mod.rsxz-core/src/lzma/fastpos_table.rsxz-core/src/lzma/lzma2_decoder.rsxz-core/src/lzma/lzma2_encoder.rsxz-core/src/lzma/lzma_decoder.rsxz-core/src/lzma/lzma_encoder.rsxz-core/src/lzma/lzma_encoder_optimum_fast.rsxz-core/src/lzma/lzma_encoder_optimum_normal.rsxz-core/src/lzma/lzma_encoder_presets.rsxz-core/src/lzma/mod.rsxz-core/src/rangecoder/mod.rsxz-core/src/rangecoder/price_table.rsxz-core/src/simple/arm.rsxz-core/src/simple/arm64.rsxz-core/src/simple/armthumb.rsxz-core/src/simple/ia64.rsxz-core/src/simple/mod.rsxz-core/src/simple/powerpc.rsxz-core/src/simple/riscv.rsxz-core/src/simple/simple_coder.rsxz-core/src/simple/simple_decoder.rsxz-core/src/simple/simple_encoder.rsxz-core/src/simple/sparc.rsxz-core/src/simple/x86.rsxz-core/src/tuklib/mod.rsxz-core/src/tuklib/tuklib_cpucores.rsxz-core/src/tuklib/tuklib_physmem.rsxz-core/src/types.rsxz-sys/Cargo.tomlxz-sys/src/lib.rs
Summary by CodeRabbit