chore: ensure /describe is not called on Database page in v2 navigation

[Copilot]

PRs #3668/#3669 removed all /describe calls from the Database page, but the mixed diagnostics context makes it easy to accidentally reintroduce them. This adds a regression test that navigates every tab of the Database page under v2 navigation and asserts /viewer/json/describe is never called.

Changes

• DiagnosticsTab enum — added missing tab values covering the full DB_PAGES set: Database, Network, Configs, Monitoring, Backups

• New test databasePageDescribeAbsence.test.ts:

  • Enables v2 navigation via localStorage before page load
  • Attaches a page.on('request') listener to collect any /viewer/json/describe hits
  • Dynamically discovers all rendered tab links (a[data-tab]) so the test stays accurate if tabs are added/removed
  • Clicks through every tab, waits for networkidle to flush triggered requests, then asserts zero /describe calls

page.on('request', (request) => {
    if (request.url().includes('/viewer/json/describe')) {
        describeCalls.push(request.url());
    }
});

// ...navigate to databasePage: 'database' with v2 nav enabled...

const tabLinks = tabsContainer.locator('a[data-tab]');
for (let i = 0; i < await tabLinks.count(); i++) {
    await tabLinks.nth(i).click();
    await page.waitForLoadState('networkidle', {timeout: VISIBILITY_TIMEOUT});
}

expect(describeCalls).toHaveLength(0);

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total	Passed	Failed	Flaky	Skipped
648	643	0	2	3

Test Changes Summary ✨1 🗑️13

✨ New Tests (1)

1. /describe is not called when navigating through Database page tabs (tenant/diagnostics/tabs/databasePageDescribeAbsence.test.ts)

🗑️ Deleted Tests (13)

1. renders the new storage layout in light theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
2. renders grouped summary sections for multiple storage types in light theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
3. renders the new storage layout in dark theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
4. renders grouped summary sections for multiple storage types in dark theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
5. shows quota missing helpmark for a single-media user data summary without quota (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
6. shows quota missing helpmark only for multi-media rows without quota (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
7. keeps legacy dedicated storage layout when experiment is disabled (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
8. highlights hovered storage segment and shows rich tooltip in light theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
9. shows tooltip on legend hover and clears state after click in light theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
10. highlights hovered storage segment and shows rich tooltip in dark theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
11. shows tooltip on legend hover and clears state after click in dark theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
12. keeps legacy dedicated storage layout when storage_stats capability is unavailable (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
13. keeps legacy serverless storage layout when experiment is enabled (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)

Bundle Size: ✅

Current: 63.75 MB | Main: 63.75 MB
Diff: 0.00 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information

• Test recordings for failed tests are available in the full report.
• Bundle size is measured for the entire 'dist' directory.
• 📊 indicates links to detailed reports.
• 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

[Raubzeug]

@copilot check tests, it failed

[Copilot]

@copilot check tests, it failed

Fixed in aff70a7. The test was timing out because enabling v2 navigation triggers a "Navigation is here now" alert popover that was overlaying the tabs and blocking clicks. Added localStorage.setItem('isV2NavigationAlertSeen', JSON.stringify(true)) to the beforeEach to pre-dismiss the alert.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• ydb-platform.github.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Raubzeug]

@copilot tests are broken and not running at all! Fix the problem!

[Copilot]

@copilot tests are broken and not running at all! Fix the problem!

Fixed in 83107ce. The root cause was page.waitForLoadState('networkidle') — the live YDB backend continuously polls in the background, so networkidle never settles. Every tab visit would time out after the full 10 s VISIBILITY_TIMEOUT, causing one test to consume 60+ seconds (6 tabs × 10 s each) and stall all 8 CI shards until the 30-minute job limit was hit.

The fix replaces tab.click() + waitForLoadState('networkidle') with:

1. Collect all tab href values from the rendered DOM
2. Navigate to each tab URL directly via page.goto(href) (which waits for the load event — fast and deterministic)
3. Wait for the diagnostics container to confirm the page has rendered

Also added test.setTimeout(60_000) to give this multi-tab test a generous but explicit budget.

[Raubzeug]

@copilot this timeout will increase test time a lot! suggest another way.

[Copilot]

@copilot this timeout will increase test time a lot! suggest another way.

Removed in 6517798. Since the test now uses page.goto() instead of networkidle, each tab navigation takes ~2s, so 6 tabs ≈ 12–15s total — well within the default 30s timeout. No custom timeout needed.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6517798901

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Copilot]

Pull request overview

Adds a Playwright regression test to prevent accidental reintroduction of /viewer/json/describe requests when navigating across the Database page tabs under v2 tenant navigation. This supports the recent work in #3668/#3669 to keep the Database page functional for users who may not have describe permissions.

Changes:

• Adds a new e2e test that enables v2 navigation, iterates through all rendered Database page tabs, and asserts /viewer/json/describe is never requested.
• Extends the DiagnosticsTab enum in the test page model to include the missing tab IDs needed to represent the full DB_PAGES set (e.g., database, network, configs, monitoring, backups).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/suites/tenant/diagnostics/tabs/databasePageDescribeAbsence.test.ts	New Playwright regression test to ensure no /viewer/json/describe requests occur while traversing Database page tabs (v2 nav).
tests/suites/tenant/diagnostics/Diagnostics.ts	Expands DiagnosticsTab enum to cover additional Database-page tab IDs used by v2 navigation.

[Raubzeug]

@copilot check review comments and fix what is sensible

[Copilot]

@copilot check review comments and fix what is sensible

Fixed in e67db0b. Two changes from the Greptile review:

1. Silently-skipped tabs — each tab's href is now asserted to be non-null before being pushed into tabHrefs, so any <a data-tab> without an href fails the test loudly instead of being silently skipped.

2. Deferred requests escaping the assertion window — added await page.waitForTimeout(500) after the navigation loop (once, before the final assertion) to let any deferred effects on the last tab fire before asserting. This adds only 500 ms to the test.

[Raubzeug]

@copilot fix linter issues

[Copilot]

@copilot fix linter issues

Fixed in 434fb3f. The expect(href, message) call on line 49 had its arguments on one line, exceeding Prettier's print width. Split into multi-line form.