feat: database storage by astandrik · Pull Request #3829 · ydb-platform/ydb-embedded-ui

astandrik · 2026-04-21T17:56:37Z

CI Results

Test Status: ⚠️ FLAKY

Total	Passed	Failed	Flaky	Skipped
672	667	0	2	3

Test Changes Summary ✨13

✨ New Tests (13)

renders the new storage layout in light theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
renders grouped summary sections for multiple storage types in light theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
renders the new storage layout in dark theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
renders grouped summary sections for multiple storage types in dark theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
shows quota missing helpmark for a single-media user data summary without quota (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
shows quota missing helpmark only for multi-media rows without quota (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
keeps legacy dedicated storage layout when experiment is disabled (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
highlights hovered storage segment and shows rich tooltip in light theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
shows tooltip on legend hover and clears state after click in light theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
highlights hovered storage segment and shows rich tooltip in dark theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
shows tooltip on legend hover and clears state after click in dark theme (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
keeps legacy dedicated storage layout when storage_stats capability is unavailable (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)
keeps legacy serverless storage layout when experiment is enabled (tenant/diagnostics/tabs/tenantOverviewStorage.test.ts)

Bundle Size: 🔺

Current: 63.75 MB | Main: 63.56 MB
Diff: +0.19 MB (0.30%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information

Test recordings for failed tests are available in the full report.
Bundle size is measured for the entire 'dist' directory.
📊 indicates links to detailed reports.
🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af8b54f226

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Implements a new “Storage” tab layout for Tenant Overview (behind an experiment flag and gated by /viewer/storage_stats capability), including data fetching/normalization for storage stats and top space consumers.

Changes:

Added new tenant storage raw-data RTK Query endpoint (storage stats + .sys/partition_stats query + schema lookups) and client-side normalization utilities.
Introduced a new Storage UI (TenantStorageNew) with per-media summaries, segmented breakdowns, and a “Top 10 by space usage” table, plus a mode switch to keep the legacy layout when needed.
Updated API/types and normalization helpers (media type normalization, tenant storage/quota fields), and added unit + Playwright coverage.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/suites/tenant/diagnostics/tabs/tenantOverviewStorage.test.ts	Playwright coverage for new/legacy storage layout switching and key UI assertions
src/utils/disks/normalizeMediaType.ts	Normalize media kinds to uppercase and stabilize `Unknown` handling
src/types/api/tenant.ts	Adds `DatabaseStorage` and quota fields (`storage_quotas`, `SoftQuota`, `HardQuota`) to tenant API types
src/types/api/storage.ts	Makes `StorageStatsRequestParams.path` optional (supports tablet-type aggregation calls)
src/store/reducers/tenants/utils.ts	Uses `DatabaseStorage` / `TablesStorage` and per-type quotas to compute tenant storage stats
src/store/reducers/tenantOverview/storage/tenantOverviewStorage.ts	New RTK Query endpoint to fetch raw storage data (tablet stats, top objects, schema metadata)
src/store/reducers/storageUsage/test/storageUsage.test.ts	Adds test for lowercase media kind normalization (`ssd` → `SSD`)
src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json	Adds i18n strings for the new storage UI
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts	Builds view-model for new storage UI (summaries, segments, media sections, top rows)
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/useTenantStorageNewData.ts	Hook that fetches raw storage data and memoizes normalized view-model
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/types.ts	Shared prop/metrics types for storage components
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/test/utils.test.ts	Unit tests for storage view-model builders and helpers
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorageNew.tsx	New Storage tab UI implementation (summaries + top-usage table)
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorageNew.scss	Styles for the new storage UI
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorageMode.tsx	Switches between legacy and new storage UIs based on flags/capabilities/type
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorage.tsx	Refactors legacy storage component to reuse shared prop/types
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.tsx	Wires `TenantStorageMode` into the Storage tab and passes required props
src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/MetricsTabs.tsx	Adjusts which storage stats set is used for aggregates (prefers stats with limits)
src/containers/Cluster/ClusterOverview/utils.tsx	Hardens diagram fill calculation against invalid/zero capacities

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6fcc447e21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b59088916

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eeee446ca0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c72d94648

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-06T17:30:11Z

💡 Codex Review

ydb-embedded-ui/src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts

Lines 331 to 332 in 48b4528

    
           if (segments || systemDetails || !allowAggregateFallback || mediaKey === EType.None) { 
        
               return {segments, systemDetails};

Merge aggregate tablet breakdown with per-media data

When a single-media database gets tablet-type rows where some rows include Media (for example DataShard on SSD) but older/system tablet rows only provide row-level StorageSize, the aggregate system rows are stored under EType.None while the SSD row makes segments truthy here. Fresh evidence in the current code is that this guard returns immediately as soon as segments exists, so the aggregate system segment/details are not used and the physical card reports that storage as unknown instead of system usage.

ydb-embedded-ui/src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts

Lines 623 to 625 in 48b4528

    
           const userStats = 
        
               tabletStatsByType.get(mediaType) ?? 
        
               (mediaTypes.length === 1 ? tabletStatsByType.get(EType.None) : undefined);

Avoid zeroing aggregate user stats in media groups

On clusters where blob stats are split by media (SSD/HDD) but tablet/user stats are only aggregate under EType.None, this lookup intentionally falls back only for a single media section. With multiple media sections, userStats is undefined for every row, so the grouped User data card renders 0 used/quota for each media even though aggregate tablet usage exists; this misreports user storage rather than showing an aggregate/unknown split.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66f40d1a67

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc4077c9a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

astandrik · 2026-05-07T14:48:33Z

@Raubzeug fixes issues

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc2acb2dde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI review requested due to automatic review settings April 21, 2026 17:56

astandrik requested review from Raubzeug and adameat as code owners April 21, 2026 17:56

Copilot started reviewing on behalf of astandrik April 21, 2026 17:57 View session

greptile-apps Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread src/store/reducers/tenantOverview/storage/tenantOverviewStorage.ts Outdated

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorageNew.tsx Outdated

chatgpt-codex-connector Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread src/store/reducers/tenantOverview/storage/tenantOverviewStorage.ts Outdated

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorageNew.tsx Outdated

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorageNew.tsx Outdated

Comment thread src/store/reducers/tenants/utils.ts Outdated

Comment thread src/store/reducers/tenants/utils.ts Outdated

chatgpt-codex-connector Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts Outdated

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread src/store/reducers/tenants/utils.ts Outdated

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts Outdated

chatgpt-codex-connector Bot reviewed Apr 27, 2026

View reviewed changes

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts Outdated

Comment thread src/store/reducers/tenants/utils.ts Outdated

astandrik added 8 commits April 29, 2026 12:28

feat: database storage

83c5a0d

fix: some fixes

b0067b0

fix: review fixes

9e038f9

fix: review fixes

25e2668

fix: data space usage

ff1fad1

fix: design fixes 1

d4432e2

fix: design review 2

985fa47

fix: tooltip

2c72d94

astandrik force-pushed the astandrik.3779-2 branch from eeee446 to 2c72d94 Compare May 4, 2026 09:06

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Comment thread tests/suites/tenant/diagnostics/tabs/tenantOverviewStorage.test.ts Outdated

astandrik added 5 commits May 4, 2026 13:57

fix: refactor

06ddbdb

fix: design fixes

b42b6ad

fix: design fixes

aa9d615

fix: refine new storage layout and tooltips

1798637

test: update new storage snapshots

6fe846a

greptile-apps Bot reviewed May 5, 2026

View reviewed changes

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts

astandrik added 4 commits May 5, 2026 19:38

test: update tenant storage screenshots

ac47f66

test: add full tenant storage screenshots

99e79cc

test: update tenant storage table screenshots

e14c455

test: update tenant storage table snapshots

2f78929

fix: preserve aggregate storage breakdown

b7f9087

greptile-apps Bot reviewed May 6, 2026

View reviewed changes

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/utils.ts

fix: handle unknown tenant storage media

94cfe86

astandrik requested a review from kkdras as a code owner May 6, 2026 14:53

This comment has been minimized.

Sign in to view

astandrik added 2 commits May 6, 2026 20:25

fix: classify old system tablet storage

41654b4

Merge branch 'main' into astandrik.3779-2

48b4528

astandrik requested a review from Copilot May 6, 2026 17:33

Copilot started reviewing on behalf of astandrik May 6, 2026 17:34 View session

fix: handle aggregate tenant storage media

66f40d1

chatgpt-codex-connector Bot reviewed May 6, 2026

View reviewed changes

Comment thread src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorageSummarySections.tsx

astandrik added 3 commits May 6, 2026 21:47

fix: some formatting fixes

7472fdd

fix: display refactoring

25cb600

fix: legacy storage

fc4077c

chatgpt-codex-connector Bot reviewed May 7, 2026

View reviewed changes

Comment thread src/store/reducers/tenantOverview/storage/tenantOverviewStorage.ts Outdated

fix: handle partial tenant storage breakdown

fa65b4e

Raubzeug requested changes May 7, 2026

View reviewed changes

fix: review fixes

cc2acb2

chatgpt-codex-connector Bot reviewed May 7, 2026

View reviewed changes

Comment thread src/utils/utils.ts

Raubzeug previously approved these changes May 7, 2026

View reviewed changes

fix: review fix

e41d4c5

astandrik dismissed Raubzeug’s stale review via e41d4c5 May 8, 2026 08:36

Raubzeug approved these changes May 8, 2026

View reviewed changes

astandrik added this pull request to the merge queue May 8, 2026

Merged via the queue into main with commit 258635b May 8, 2026
20 checks passed

astandrik deleted the astandrik.3779-2 branch May 8, 2026 10:32

ydb-platform-bot mentioned this pull request May 7, 2026

chore(main): release 15.6.0 #3865

Open

Conversation

astandrik commented Apr 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Results

Test Status: ⚠️ FLAKY

✨ New Tests (13)

Bundle Size: 🔺

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

chatgpt-codex-connector Bot commented May 6, 2026

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

astandrik commented May 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

astandrik commented Apr 21, 2026 •

edited by github-actions Bot

Loading