Fix: Names the Experimental ESM support warning#7069
Open
NormalGaussian wants to merge 1 commit intoyarnpkg:masterfrom
Open
Fix: Names the Experimental ESM support warning#7069NormalGaussian wants to merge 1 commit intoyarnpkg:masterfrom
NormalGaussian wants to merge 1 commit intoyarnpkg:masterfrom
Conversation
Open
1 task
Contributor
Author
|
It may be desirable to use an EXPERIMENTAL name rather than one so specific? |
Member
|
Yeah, probably |
6db7228 to
b1f40f2
Compare
Contributor
Author
|
I've updated it to be EXPERIMENTAL |
Member
|
Please also add a simple description to packages/docusaurus/docs/advanced/01-general-reference/error-codes.mdx |
b1f40f2 to
87f919d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names the ESM experimental loading warning
What's the problem this PR addresses?
Simple justification: unnamed logs should be avoided
More complex justifiation:
Lots of workspaces now are esm by default. This warning will appear on all of them. While it is "true", there is a strong desire to filter it out so that it does not:
Unnamed logs cannot be filtered.
How did you fix it?
I've added a new name for the warning, and made the warning use that name
Checklist