Skip to content

Auto-update polyscope to v2.6.1#9921

Open
waruqi wants to merge 1 commit intodevfrom
autoupdate-polyscope-v2.6.1
Open

Auto-update polyscope to v2.6.1#9921
waruqi wants to merge 1 commit intodevfrom
autoupdate-polyscope-v2.6.1

Conversation

@waruqi
Copy link
Copy Markdown
Member

@waruqi waruqi commented May 7, 2026

New version of polyscope detected (package version: v2.5.0, last github version: v2.6.1)

@waruqi waruqi added the auto-update Automatic update label May 7, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Polyscope version 2.6.1. Feedback suggests updating the imgui dependency constraint in the on_load block to accommodate Polyscope's support for imgui 1.91+ in newer versions.

add_urls("https://github.com/nmwsharp/polyscope/archive/refs/tags/$(version).tar.gz",
"https://github.com/nmwsharp/polyscope.git")

add_versions("v2.6.1", "c8e7b0f0791348fa54201f146c8b689eaf2ac05b9d419a36bc5577a7c21e24e1")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The addition of v2.6.1 likely requires an update to the imgui dependency constraint in the on_load block (line 38). Polyscope v2.6.0 and later versions have updated their codebase to support imgui 1.91+, so the current <1.91 restriction should be relaxed or removed for this new version to ensure compatibility and allow users to use the latest features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant