Open
Conversation
| add_urls("https://github.com/nmwsharp/polyscope/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/nmwsharp/polyscope.git") | ||
|
|
||
| add_versions("v2.6.1", "c8e7b0f0791348fa54201f146c8b689eaf2ac05b9d419a36bc5577a7c21e24e1") |
Contributor
There was a problem hiding this comment.
The addition of v2.6.1 likely requires an update to the imgui dependency constraint in the on_load block (line 38). Polyscope v2.6.0 and later versions have updated their codebase to support imgui 1.91+, so the current <1.91 restriction should be relaxed or removed for this new version to ensure compatibility and allow users to use the latest features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of polyscope detected (package version: v2.5.0, last github version: v2.6.1)