update armadillo to 15.2.6#9903
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version 15.2.6 to the Armadillo package configuration. Feedback indicates that this version number is likely incorrect for the Armadillo C++ library, where the latest stable release is 14.2.2, and suggests correcting the version and updating the test block to C++17 to accommodate the requirements of newer releases.
| set_license("Apache-2.0") | ||
|
|
||
| add_urls("http://sourceforge.net/projects/arma/files/armadillo-$(version).tar.xz") | ||
| add_versions("15.2.6", "97cb8ef708541f632e861d005a462dd0367240f81ff96f8e63ebbdd75c8ce55f") |
There was a problem hiding this comment.
The version 15.2.6 does not exist for the Armadillo C++ linear algebra library. The latest stable release is 14.2.2. It appears this version number may have been confused with another software of the same name. Additionally, Armadillo 14.0 and later require C++17, so the on_test block at line 53 should be updated to use c++17 instead of c++14 to ensure the package can be verified correctly.
add_versions("14.2.2", "6e10669665163a60e6493913f1ad7290168da4a939c64531370896d7bc623ad1")
|
这个 mingw(msys32) 和包无关，CI prepare阶段就不行了 |
This mingw(msys32) has nothing to do with the package, not the CI prepare stage. |
2 participants
update armadillo to 15.2.6