Skip to content

Auto-update nodeeditor to 3.0.16 #9876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waruqi wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Auto-update nodeeditor to 3.0.16 #9876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/n/nodeeditor/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package("nodeeditor")

set_urls("https://github.com/paceholder/nodeeditor/archive/refs/tags/$(version).tar.gz",
"https://github.com/paceholder/nodeeditor.git")
add_versions("3.0.16", "453e6eb783379fee6edf9282283576eaa7d27349b8731e638926ccbd8331f7ef")
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding version 3.0.16 is problematic because it is a major rewrite (3.x) with breaking changes that are not handled by the current xmake.lua script. Specifically:

  • C++ Standard: Version 3.x requires C++17, but the on_test block (line 48) is configured for c++14.
  • Header Paths: Includes have moved from nodes/ to QtNodes/. The on_test block will fail to find the headers.
  • API Changes: QtNodes::DataModelRegistry (line 45) has been removed in 3.x.
  • Qt Version: The script is hardcoded to Qt5 (lines 17, 26, 32), while 3.x supports and often targets Qt6.
  • Patches: The existing patches for 2.x (lines 11-12) likely do not apply to 3.x, and new ones might be needed.

The build logic and test snippets need to be updated to support both 2.x and 3.x before this version can be safely added.

add_versions("2.1.3", "4e3194a04ac4a2a2bf4bc8eb6cc27d5cc154923143c1ecf579ce7f0115a90585")
add_versions("2.2.2", "010ebcf9b68f676c81ea13ea4a541f7ba441ec3dc3b6508315c36f6466c13536")
add_patches("2.1.3", path.join(os.scriptdir(), "patches", "2.1.3", "fix_qt.patch"), "11b6e765f8c8b0002f84ef0c3eb7dde23076b0564679760b7f4c8ba7c7e46887")
Expand Down
Loading