Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the fluidsynth package in xmake.lua to include version v2.5.4. The review highlights that the new version is missing the find-intl.patch required by previous versions, which may lead to build failures on platforms like macOS and Linux. It is recommended to apply the necessary patch to ensure consistent build stability.
|
|
||
| add_urls("https://github.com/FluidSynth/fluidsynth/archive/refs/tags/$(version).zip", | ||
| "https://github.com/FluidSynth/fluidsynth.git") | ||
| add_versions("v2.5.4", "8472516e717ce583083a52a68f8840954d18d2d56be770f2d335f42b76417900") |
Contributor
There was a problem hiding this comment.
The version v2.5.4 is added without the find-intl.patch that was applied to previous versions (v2.3.3 and v2.3.5). This will likely cause build failures on platforms requiring libintl (such as macOS and Linux) if the issue hasn't been resolved upstream. It is recommended to include the patch for this version as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of fluidsynth detected (package version: v2.3.5, last github version: v2.5.4)