More various fixes (F-*)#107
Open
gasbytes wants to merge 10 commits intowolfSSL:masterfrom
Open
Conversation
Contributor
gasbytes
commented
Apr 30, 2026
gasbytes
commented
- Guard wolfIP_sock_socket against a NULL stack pointer to prevent segfaults in tcp_new_socket/udp_new_socket/icmp_new_socket/raw_new_socket/packet_new_socket (1037af7).
- Add martian + strict-RPF source filtering to ip_recv's forwarding relay path, dropping spoofed loopback, link-local, and wrong-interface sources before wolfIP_forward_interface (2d6edbb).
- Replace signed-int shift reassembly in dns_callback's A-record path with a safe get_be32 helper to avoid ISO C11 6.5.7p4 UB on high-bit top octets (b203126).
- Add a udp.len <= ip.len - IP_HEADER_LEN guard in udp_try_recv so L2-padded frames can no longer leak post-IP bytes through recvfrom (95bc67b).
- Add a regression test pinning the IGMP checksum guard in igmp_input (73fc1b1).
- Reject sub-ETH_HEADER_LEN buffers at the top of wolfIP_recv_on's ethernet branch to prevent OOB reads in the filter callback and eth->type/eth->dst comparisons (671d5ad).
- Add a regression test pinning RFC 9293 §3.10.7.3 SND.UNA < SEG.ACK <= SND.NXT bounds on the SYN_SENT RST+ACK path in tcp_input (60f7c31).
- Gate request-side arp_store_neighbor on a matching arp_pending_match_and_clear so unsolicited ARP requests can no longer poison the neighbor cache and lock out legitimate replies (7d92e8b).
- Add a tcp_time_wait branch in tcp_input that re-ACKs non-RST/SYN matched segments, per RFC 9293 §3.10.7.4, so retransmitted peer FINs after a lost final ACK aren't silently dropped (b700877).
non-rst/syn matched segment so retransmitted peer FINSs caused by a lost final ack are acknowledged (per rereference from 9293 section 3.10.7.4) instead of silently dropped.
…nding_match_and_clear so unsolicited ARP requests can no longer fill the neighbor cache and lock out legitimate replies, with test_arp_request_flood_does_not_lock_out_legit_reply as regression test. Updated three pre-existing tests to model the now-required solicited-learn path.
….7.3 SND.UNA < SEG.ACK <= SND.NXT on the SYN_SENT RST+ACK path so deletion of the upper-bound clause and < <-> <= boundary mutations on either bound in tcp_input no longer slip past CI.
…on's ethernet branch so the eth filter callback and the eth->type/eth->dst comparisons can no longer read past the end of a runt caller-supplied buffer, with test_wolfip_recv_ex_runt_eth_frame_drops_before_filter pinning the contract.
…ecksum guard in igmp_input so deletion of the rejection branch can no longer slip past CI.
…2-padded frame whose UDP length overruns its IP packet's declared length can no longer leak post-IP bytes through recvfrom (per RFC 768 / RFC 791), with test_regression_udp_len_exceeds_ip_len_dropped pinning the contract.
…s A-record path with the safe memcpy+ee32 get_be32 helper (hoisted out of the IP_MULTICAST gate so it is unconditionally available) so a high-bit top octet (>= 0x80) can no longer trigger ISO C11 6.5.7p4 undefined behavior on the int shift, with test_regression_dns_callback_high_bit_octet_ip_no_ub pinning the contract under -fsanitize=undefined.
…ORWARDING relay path so packets sourced from 127.0.0.0/8 on a non-loopback ingress, 169.254.0.0/16 link-local, or any locally-configured subnet on the wrong interface are dropped before wolfIP_forward_interface, with test_regression_forwarding_rpf_drops_spoofed_source pinning the contract.
…a NULL stack pointer no longer segfaults inside tcp_new_socket/udp_new_socket/icmp_new_socket/raw_new_socket/packet_new_socket, with test_regression_sock_socket_null_wolfip_returns_einval pinning the contract.
…gate, since the forwarding rpf code uses them uncoditionally now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.